Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jsonista dep to latest #129

Open
harold opened this issue Jun 30, 2022 · 0 comments
Open

Update jsonista dep to latest #129

harold opened this issue Jun 30, 2022 · 0 comments

Comments

@harold
Copy link

harold commented Jun 30, 2022

Hi! Thanks as ever for muuntaja, we do a lot of requests every day through this middlware and it works extremely well. Very grateful to you.

It appears that the latest jsonista cleans up some reflection warnings we are seeing in our compilation steps.

Would it make sense to update muuntaja to use the latest jsonista?

harold@zion:~/src/muuntaja [master]$ lein check
Compiling namespace muuntaja.core
Reflection warning, jsonista/core.clj:139:19 - call to method registerModule can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:140:19 - call to method registerModule can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:142:39 - call to method enable can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:143:44 - call to method enable can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:144:71 - reference to field getFactory can't be resolved.
Reflection warning, jsonista/core.clj:144:71 - call to method enable can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:146:8 - call to method registerModule can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:146:8 - call to method registerModule can't be resolved (target class is unknown).
Reflection warning, jsonista/core.clj:147:6 - call to method disable can't be resolved (target class is unknown).
Compiling namespace muuntaja.format.cheshire
Compiling namespace muuntaja.format.core
Compiling namespace muuntaja.format.edn
Compiling namespace muuntaja.format.form
Compiling namespace muuntaja.format.json
Compiling namespace muuntaja.format.msgpack
Compiling namespace muuntaja.format.transit
Compiling namespace muuntaja.format.yaml
Compiling namespace muuntaja.interceptor
Compiling namespace muuntaja.middleware
Compiling namespace muuntaja.parse
Compiling namespace muuntaja.protocols
Compiling namespace muuntaja.util
harold@zion:~/src/muuntaja [master]$ lein ancient | grep jsonista
[metosin/jsonista "0.3.6"] is available but we use "0.3.1"
harold@zion:~/src/muuntaja [master]$ sed -i 's/0.3.1/0.3.6/g' project.clj 
harold@zion:~/src/muuntaja [master]$ git diff project.clj
diff --git a/project.clj b/project.clj
index 367c9ed..48592c2 100644
--- a/project.clj
+++ b/project.clj
@@ -5,7 +5,7 @@
             :url "http://www.eclipse.org/legal/epl-v20.html"}
   :managed-dependencies [[metosin/muuntaja "0.6.8"]
                          [ring/ring-codec "1.1.2"]
-                         [metosin/jsonista "0.3.1"]
+                         [metosin/jsonista "0.3.6"]
                          [com.cognitect/transit-clj "1.0.324"]
                          [cheshire "5.10.0"]
                          [clj-commons/clj-yaml "0.7.106"]
harold@zion:~/src/muuntaja [master]$ lein check
Retrieving metosin/jsonista/0.3.6/jsonista-0.3.6.pom from clojars
Retrieving metosin/jsonista/0.3.6/jsonista-0.3.6.jar from clojars
Compiling namespace muuntaja.core
Compiling namespace muuntaja.format.cheshire
Compiling namespace muuntaja.format.core
Compiling namespace muuntaja.format.edn
Compiling namespace muuntaja.format.form
Compiling namespace muuntaja.format.json
Compiling namespace muuntaja.format.msgpack
Compiling namespace muuntaja.format.transit
Compiling namespace muuntaja.format.yaml
Compiling namespace muuntaja.interceptor
Compiling namespace muuntaja.middleware
Compiling namespace muuntaja.parse
Compiling namespace muuntaja.protocols
Compiling namespace muuntaja.util
harold@zion:~/src/muuntaja [master]$ lein test
WARNING: Inst already refers to: #'clojure.core/Inst in namespace: schema.core, being replaced by: #'schema.core/Inst

lein test muuntaja.core-test

lein test muuntaja.interceptor-test

lein test muuntaja.middleware-test

lein test muuntaja.parse-test

lein test muuntaja.protocols-test

lein test muuntaja.ring-json.json-test

lein test muuntaja.ring-middleware.format-params-test

lein test muuntaja.ring-middleware.format-response-test

lein test muuntaja.ring-middleware.format-test

Ran 54 tests containing 345 assertions.
0 failures, 0 errors.

Regardless, thanks as ever for your efforts, time, and consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant