Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json-schema for body responses #127

Closed
davidjameshumphreys opened this issue Aug 23, 2017 · 1 comment
Closed

Json-schema for body responses #127

davidjameshumphreys opened this issue Aug 23, 2017 · 1 comment

Comments

@davidjameshumphreys
Copy link
Contributor

When defining response bodies for routes we'd like to use ring.swagger.json-schema.

(rjsj/describe {:body ...} "Reason")

This gets around some restrictions that we found when interacting with other libraries.
davidjameshumphreys added a commit to davidjameshumphreys/ring-swagger that referenced this issue Aug 23, 2017
@davidjameshumphreys
Allow meta descriptions for response bodies
b5db9c8 
When describing body responses for a route definition consider the
metadata from the json-schema namespace.

Fixes metosin#127
@davidjameshumphreys davidjameshumphreys mentioned this issue Aug 23, 2017
Merged
@ikitommi
Copy link
Member

awesome, thanks! At some point when, we'll move the schema meta-data (and coercion) utilities from ring-swagger to schema-tools. Clean apis, similar/identical for both schema and spec. Already done for the spec side.

metosin/schema-tools#32
metosin/spec-tools#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidjameshumphreys @ikitommi