Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RouteConfigurationInterface::PARAMETER_IDENTIFIER contains pre-migration expressive naming #34

Open
boesing opened this issue Jul 26, 2021 · 0 comments
Open

RouteConfigurationInterface::PARAMETER_IDENTIFIER contains pre-migration expressive naming #34

boesing opened this issue Jul 26, 2021 · 0 comments
Labels
BC Break Bug Something isn't working

Comments

@boesing
Copy link
Member

boesing commented Jul 26, 2021

Bug Report

Q A
Version(s) 1.0.4

Summary

The route configuration constant RouteConfigurationInterface::PARAMETER_IDENTIFIER contains expressive.cors and thus still contains the pre-migration value which I actually missed when porting to mezzio.

Current behavior

Constant value reflects expressive.cors.

How to reproduce

n/a

Expected behavior

Constant value reflects mezzio.cors.
When the constant value is changed, we should also grab the old route parameter expressive.cors from the configuration until the next major version.
@boesing boesing added BC Break Bug Something isn't working labels Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC Break Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@boesing