Router service name should be configurable

[gsteel]

If the router service name was configurable, we wouldn't have to re-implement this factory when the router you want to use is not aliased to RouterInterface::class

mezzio-cors/src/Service/ConfigurationLocatorFactory.php

Line 22 in a61a344

$router = $container->get(RouterInterface::class);

[boesing]

WHY would the router not properly aliased to the interface? if that is the case, the application would not pick that router up for routing either and thus would not match?

thats the whole point of how routing works in mezzio:

https://github.com/mezzio/mezzio-router/blob/4.0.x/src/RouteCollectorFactory.php

Everything basically uses that service aliased to the interface, so the cors component should do that as well.

I would suggest to streamline those projects you have issues with rather than adding workarounds in components.

[gsteel]

We have existing form for this:

https://github.com/mezzio/mezzio-helpers/blob/5.17.x/src/UrlHelperFactory.php

In my case, I have 2 applications running out of the same code-base, each with a different router instance in the container along with a different set of routes.

[boesing]

Interesting. I'd rather ensure having proper configuration when bootstrapping but as there is already this kind of magic, go ahead. 🤷🏼‍♂️

[gsteel]

I don't think I'd call it magic though - it's just configuration for "what service id gives me a router?", defaulting to the accepted norm.