Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend watchpoint callback system #3369

Open
DBM89 opened this issue Dec 11, 2024 · 0 comments
Open

Extend watchpoint callback system #3369

DBM89 opened this issue Dec 11, 2024 · 0 comments
Labels
feature:scripting Issues in the scripting subsystem severity:enhancement Feature requests
Milestone

Comments

@DBM89
Copy link

DBM89 commented Dec 11, 2024

In VBA-RR, when running the following function
local function func(address)
local addr = memory.readbyte(address)
end
memory.registerwrite(0x4000130, func)
Variable addr would contain new written value
In mGBA, below code will fail, since mGBA passes no values
emu:setWatchpoint(func, 0x4000130, C.WATCHPOINT_TYPE.WRITE)
Moreover, when you check memory it doesn't provide new value
BizHawk passes the address that receives an event action as well as the new value.
Please fix the Lua engine so it behaves like VBA-RR or at least pass same values that BizHawk.
I want to know new value, I have no need for old value

@endrift endrift changed the title Lua event callback system broken Extend watchpoint callback system Dec 22, 2024
@endrift endrift added severity:enhancement Feature requests feature:scripting Issues in the scripting subsystem labels Dec 22, 2024
@endrift endrift added this to the mGBA 0.11.0 milestone Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:scripting Issues in the scripting subsystem severity:enhancement Feature requests
Projects
None yet
Development

No branches or pull requests

2 participants