Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit escaping throughout #37

Open
mgree opened this issue Sep 9, 2020 · 0 comments
Open

Explicit escaping throughout #37

mgree opened this issue Sep 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@mgree
Copy link
Owner

mgree commented Sep 9, 2020

With #36 (a fix for #21, among other things), escaping is explicit in words. It's still the case that expanded_words and intermediate_fields use backslashes to escape things. It would be good to have explicit escapes throughout, though getting all the details right will be tricky.
@mgree mgree added the enhancement New feature or request label Sep 9, 2020
mgree pushed a commit that referenced this issue Sep 9, 2020
@tucak
Add escaped characters to the AST (#36)
55bb5bc 
To represent characters escaped by a backslash, a new AST entry is
added. This improves their handling considerably compared to the
previous state, where the escaping was in some cases ignored and in
other cases turned into a literal backslash.

The change has not yet been pushed "all the way through": `expanded_words` and `intermediate_fields` still use backslashes for escaping. That fix is a longer-term issue (#37).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mgree