Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be nice to slice a Table #23

Open
jmcarter17 opened this issue Apr 24, 2020 · 2 comments
Open

Would be nice to slice a Table #23

jmcarter17 opened this issue Apr 24, 2020 · 2 comments

Comments

@jmcarter17
Copy link

Now that this works for me, I have been playing with it and it works great,
however, it would be nice if we could slice a Table.

It is currently not supported, but it would be great I think.

@mherrmann
Copy link
Owner

mherrmann commented Apr 25, 2020

I don't understand the point of opening this issue. You're saying "feature XYZ would be nice". Okay. It's nice when the sun shines. What's your point? Do you want me to implement it, will you implement it, do you just want to kick off a discussion? If the last, how are you going to contribute to this?

Here's where I'm coming from: I maintain this library in my spare time and am offering my free time voluntarily to do so. Your message above is like saying "I want ice cream". How am I, or other users of this library, incentivized to help you? What will you contribute? Generally, I will not spend time implementing feature requests to this library unless someone pays me to do it. But I will merge PRs if they are good. So if you want this, I'd kindly ask that you please bring some more input to the table than saying "it would be great".

@jmcarter17
Copy link
Author

Sorry @mherrmann, didn't want to make such a big deal out of it. I thought I would start a discussion and see if other people would also find it helpful. Maybe other people have also thought of it. Or maybe they found a way to do it with the current state of the library. You are right, it is only something that would be nice, and not necessary, so maybe creating an issue is not the right way to bring this discussion to the table. However, if there is another way, I don't know of it.

As for implementing it myself and doing a pr, I might do that. Right now, I'm simply familiarize myself with the library, but maybe I could try to do that eventually.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants