-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: build a deck (with cards, translations) #9
Comments
It's unclear right now if we should be using the supabase/nextjs Auth Helpers. I think no? Maybe yes and then no? I don't want the code to be so specific that it relies too heavily on this one stack, but I would be happy to save work with a dedicated library. Looking at the examples though, it doesn't look like less code. This is a moment to decide on what pattern I will support for this app's data fetching. I propose it goes like this:
I think this trade-off is fine! It just means not doing server-rendering things that handle authenticated data / not handling JWTs on the edge, not using middleWare. I think. And I bet it's easier on the climate too. This is something to ponder a bit before I dive in. |
Getting ready for the use of authenticated activity in the /app: |
I discovered in #22 and #23 that keeping track of different query clients could become a problem quickly. We have both public and auth'd reads and writes through the ever-convenient So in #27, and #28 I tried react-query, aborting two initial attempts with v3, and then in #29 I tried it again but using the new v4 docs version and documentation site and it clicked in much better. #30 fully removes the
So 30 is an important piece of work, but it's mostly/all groundwork for the rest of this project -- in #31 we start using the new approach to create a new deck (client side, authenticated mutations with the graphql API), and in #32 we will be able to browse all phrases in a language and choose to turn them into cards/add them to our deck. |
In #32 and #38 I added That said, I may later go back and try to use a single request with multiple queries in one, which seems to be a nice feature of GraphQL, and use a pre-generated |
Okay I'm going to declare this one done. Didn't get to "add a translation to an existing card" but then we also don't have the feature "change your status of an existing card" or "view a card without seeing its translation" (like study mode) or anything like that so card management and card detail can be a separate block of work for another issue/epic. |
This is the feature set that originally motivated the switch to GraphQL so we are going to start this in a graphql-first way even if the first step or 2 could be done otherwise. But we don't want to transition the whole GlobalContext object to the GraphQL fetching approach, so we will still use
useGlobalContext
.The text was updated successfully, but these errors were encountered: