Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance]Preview all windows when hovering over the icon #1092

Open
Castleeee opened this issue Feb 18, 2020 · 3 comments
Open

[Enhance]Preview all windows when hovering over the icon #1092

Castleeee opened this issue Feb 18, 2020 · 3 comments

Comments

@Castleeee
Copy link

Preview all windows when hovering over the icon,and if addMac zoom effect when the mouse passes, program start-up effect will be better

@sunbearc22
Copy link

sunbearc22 commented Feb 18, 2020

Interesting. I was just about to ask how to configure such a feature in dash-to-dock. The title says this is to be an enhancement so I guess it is not available.

I am using v3.28 due to Ubuntu 18.04. For this version, when the mouse pointer hovers over an App icon, and if the App has already opened a window or two, only the name of the App appears. Presently, I use the mouse middle-click button to preview an Apps child window(s). But this isn't efficient as a work flow.

I like to propose that when the mouse pointer hovers over an App icon, the following logic takes place:

  1. Check if the App has child windows.
    1a. If it does not, reveal the App name (current default).
    1b. If it does, then preview those child windows which I see a "preview" mode/function already exist that can be implemented.

I am not a js programmer. However, I would like to have a go at it. Can you point me to the filename I should take a look at to implement this proposed logic? Thank you.

[Update]: I think an if-loop check should be made at L416 in dash.js? I did try throwing in an if statement there (see below) but it did not seem to trigger the preview during hover. 😖 Help?

    _hookUpLabel: function(item, appIcon) {
        item.child.connect('notify::hover', Lang.bind(this, function() {
            if (appIcon.actor.hover) {
                // If any window is present, Apps windows will be previewed.
                // If not, Apps label will be shown.
                if (windows.length > 0) {
                    appIcon._windowPreviews();
                } 
                else {
                   this._syncLabel(item, appIcon);
                }
            };
        }));

@FSpark
Copy link

FSpark commented Feb 19, 2020

@sunbearc22 I'm glad that you are interested in this feature.
In fact, there were a lot of discussions before, and also a suspended merge in there #574 , which never could been merged until now and could give you some help.

Unfortunately, the author also has no time to maintain it now #574 (comment).

If you implement it, everyone will cheer and thank you!

@AlexWayfer
Copy link

Seems a duplicate of #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants