Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plural forms for translation ("Quit %d Windows" string) #2100

Closed
xalt7x opened this issue Oct 9, 2023 · 1 comment · Fixed by #2102
Closed

Support plural forms for translation ("Quit %d Windows" string) #2100

xalt7x opened this issue Oct 9, 2023 · 1 comment · Fixed by #2102

Comments

@xalt7x
Copy link
Contributor

xalt7x commented Oct 9, 2023

In appIcons.js there's a code which adds taskbar action to Quit applications/windows:

        if (this._source.windowsCount > 0) {
            if (this._source.windowsCount === 1) {
                this._quitMenuItem.label.set_text(_('Quit'));
            } else {
                this._quitMenuItem.label.set_text(__('Quit %d Windows').format(
                    this._source.windowsCount));
            }

Which leaves only one form of plural from translators:

msgid "Quit %d Windows"

For languages like Ukrainian (which can use 3 plural forms), it's impossible to translate this string correctly, covering all possible numbers of windows.

Please add support for the plural forms of this string.

Thanks.

@xalt7x xalt7x changed the title Use plural for translations ("Quit %d Windows" string) Use plural forms for translation ("Quit %d Windows" string) Oct 9, 2023
@xalt7x xalt7x changed the title Use plural forms for translation ("Quit %d Windows" string) Support plural forms for translation ("Quit %d Windows" string) Oct 9, 2023
3v1n0 added a commit to 3v1n0/dash-to-dock that referenced this issue Oct 9, 2023
@3v1n0
Copy link
Collaborator

3v1n0 commented Oct 9, 2023

Please check if #2102 helps with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants