Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework authentication UI + OAuth support #90

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

Rework authentication UI + OAuth support #90

wants to merge 18 commits into from

Conversation

devnied
Copy link
Collaborator

@devnied devnied commented Oct 6, 2024

Rework the current authentication UI and add Oauth support.

  • Add tooltip for all settings
  • Rewrite the datasource configuration UI
  • Support non encoded private key in the datasource configuration.
  • Add Oauth settings

Closes #47

@devnied
Init Oauth token authentication
3b75a09 
Add tooltip for all settings
Rewrite the datasource configuration UI
Support non encoded private key in the datasource configuration.
@devnied devnied added the enhancement New feature or request label Oct 6, 2024
@devnied devnied added this to the 1.8.0 milestone Oct 6, 2024
@devnied devnied modified the milestones: 1.8.0, 1.9.0 Oct 17, 2024
@devnied
Init Oauth token authentication
91fa5ec 
Add tooltip for all settings
Rewrite the datasource configuration UI
Support non encoded private key in the datasource configuration.
@devnied
Optimize images
c4c3d31
@devnied
Implement OAuth flow
4cfa0c4
@devnied
Add clientId & clientSecret
25908c5
@devnied
dep: Add oauth2 dependencies
3e0bd84
@devnied
Merge remote-tracking branch 'origin/master' into feature/rework-auth…
be17ada 
…entication

# Conflicts:
#	CHANGELOG.md
@devnied devnied force-pushed the feature/rework-authentication branch from 7ce34b9 to be17ada Compare November 4, 2024 22:10
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
25.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@devnied devnied marked this pull request as draft December 4, 2024 16:04
@rumbin
Copy link
Contributor

rumbin commented Dec 9, 2024

Just a heads-up:
If the OAuth support is intended to support user umpersonation, this may conflict with connection pooling #91.

@devnied
Copy link
Collaborator Author

devnied commented Dec 9, 2024

That’s a good point. However, for now, OAuth support will be limited to a single ‘Application Account’ that will handle all queries.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
50.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Feature request for Oauth connection in this plugin
2 participants
@devnied @rumbin