Feature: Asynchronous Views #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
force-pushed
the
feature/async-render
branch
from
2a09252 to
a0ef2bb
Compare
This changeset proposes a structure for an alternate `View` annotation, `AsyncView`. If `AsyncView` is used with a controller, it will try to load an `AsyncViewsRenderer` rather than a regular one, which is allowed to return a `Publisher` rather than producing an HTTP response synchronously from template context. Changes so far: - [x] Add `AsyncView` annotation - [x] Add `AsyncViewsRenderer` interface - [x] Refactor common items to `BaseViewsRenderer` - [x] Make `ViewsRenderer` comply with `BaseViewsRenderer`
sgammon
force-pushed
the
feature/async-render
branch
from
a0ef2bb to
46e261c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset proposes a structure for an alternate
Viewannotation,AsyncView. IfAsyncViewis used with a controller, it will try to load anAsyncViewsRendererrather than a regular one, which is allowed to return aPublisherrather than producing an HTTP response synchronously from template context.If merged, this fixes #15 (Async render interface).
Changes so far:
AsyncViewannotationAsyncViewsRendererinterfaceBaseViewsRendererViewsRenderercomply withBaseViewsRenderer