Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this where I can share samples for custom template layouts? #6

Open
PerOve opened this issue Jun 28, 2021 · 4 comments
Open

Is this where I can share samples for custom template layouts? #6

PerOve opened this issue Jun 28, 2021 · 4 comments

Comments

@PerOve
Copy link

PerOve commented Jun 28, 2021

I have created a few layouts, based on Handlebars partials, and stored in html files.

Is this the correct place to share those?

@wobba
Copy link
Contributor

wobba commented Jun 28, 2021

I think we can put them in a folder below https://github.com/microsoft-search/pnp-modern-search, and then add docs pages pointing to them. That or I add a separate repo for sample templates. Any opinions?

@PerOve
Copy link
Author

PerOve commented Jun 28, 2021 via email

@FranckyC
Copy link
Collaborator

FranckyC commented Jul 1, 2021

Hi @PerOve, custom templates should be stored in this repository, not in the main repository. You can create a search-html-templates folder at root and make a PR. Then you can reference them in the doc.

When the custom layout feature will be available, they will be merged into the search-extensibility-samples solution folder as available custom layouts.

@gretchunkim
Copy link

@PerOve I'd love to see samples for your custom layouts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants