-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this where I can share samples for custom template layouts? #6
Comments
I think we can put them in a folder below https://github.com/microsoft-search/pnp-modern-search, and then add docs pages pointing to them. That or I add a separate repo for sample templates. Any opinions? |
They could be inside the https://github.com/microsoft-search/pnp-modern-search.
But maybe they should be their own branch, together with docs? And not added to develop?
So it is easy to merge them often into main?
What do you think? I am not so experienced with Git.
Per Ove
…________________________________
From: Mikael Svenson ***@***.***>
Sent: Monday, June 28, 2021 3:17:28 PM
To: microsoft-search/pnp-modern-search-extensibility-samples ***@***.***>
Cc: Per Ove Sandhåland ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft-search/pnp-modern-search-extensibility-samples] Is this where I can share samples for custom template layouts? (#6)
I think we can put them in a folder below https://github.com/microsoft-search/pnp-modern-search, and then add docs pages pointing to them. That or I add a separate repo for sample templates. Any opinions?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#6 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AASF7Z6UFDYEXJ36AEX6WCLTVBY6RANCNFSM47NSOTPQ>.
|
Hi @PerOve, custom templates should be stored in this repository, not in the main repository. You can create a search-html-templates folder at root and make a PR. Then you can reference them in the doc. When the custom layout feature will be available, they will be merged into the search-extensibility-samples solution folder as available custom layouts. |
@PerOve I'd love to see samples for your custom layouts! |
I have created a few layouts, based on Handlebars partials, and stored in html files.
Is this the correct place to share those?
The text was updated successfully, but these errors were encountered: