Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical queries handles may implicitly overlap #6558

Open
maxtropets opened this issue Oct 10, 2024 · 0 comments
Open

Historical queries handles may implicitly overlap #6558

maxtropets opened this issue Oct 10, 2024 · 0 comments

Comments

@maxtropets
Copy link
Contributor

Historical adapter uses get_state_at(handle=seqno, seqno=seqno), and also calls populate_service_endorsements and populate_cose_service_endorsements in the same way.

Historical cache is exposed to the user, as well as get_state_at calls. It may happen that both framework code (inside the adapter) and user code will end up using same handle for different seqnos.

I see two possible solutions

  • adapter has to provide a way for user to control the handle
  • adapter shall use CompoundHandle (System, seqno)

The second option seems simpler and more straightforward to me.

@maxtropets maxtropets added the bug label Oct 10, 2024
@achamayou achamayou removed the bug label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants