Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project version is inconsistent with release note #169

Closed
seungha-yang opened this issue Oct 24, 2023 · 3 comments · Fixed by #200
Closed

Project version is inconsistent with release note #169

seungha-yang opened this issue Oct 24, 2023 · 3 comments · Fixed by #200

Comments

@seungha-yang
Copy link

The project version written in cmake file is 3.1.8 but it's 3.18 in release note

@nirbheek
Copy link
Contributor

It would also be good to use the project version number when making tags / releases :)

@JPeterMugaas
Copy link
Contributor

The version should be bumped up to 3.1.9.

@walbourn
Copy link
Member

walbourn commented Jan 1, 2024

I have some complexities that I have to manage here because this library ships in the windows SDK.

There is no functional change here at all.

For vcpkg, the version is the release date.

@walbourn walbourn closed this as completed Jan 1, 2024
@walbourn walbourn linked a pull request Sep 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants