From 62da54a5cc2a2627609b237f9fafbc83407cffcb Mon Sep 17 00:00:00 2001 From: Shreyash Chauhan <87440427+shreyash2002@users.noreply.github.com> Date: Mon, 24 Jun 2024 11:55:39 +0530 Subject: [PATCH 1/4] [ci] enforced shellcheck checks for .ci/trigger_dispact_run.sh; Issue(#6498) - Errors- SC2086 (info) : Double quote to prevent globbing and word splitting --- .ci/trigger_dispatch_run.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.ci/trigger_dispatch_run.sh b/.ci/trigger_dispatch_run.sh index 731450664432..4c6c6c1afe95 100755 --- a/.ci/trigger_dispatch_run.sh +++ b/.ci/trigger_dispatch_run.sh @@ -37,9 +37,9 @@ pr=$( data=$( jq -n \ --arg event_type "$dispatch_name" \ - --arg pr_number "$(echo $pr | jq '.number')" \ - --arg pr_sha "$(echo $pr | jq '.head.sha')" \ - --arg pr_branch "$(echo $pr | jq '.head.ref')" \ + --arg pr_number "$(echo "$pr" | jq '.number')" \ + --arg pr_sha "$(echo "$pr" | jq '.head.sha')" \ + --arg pr_branch "$(echo "$pr" | jq '.head.ref')" \ --arg comment_number "$comment_id" \ '{"event_type":$event_type,"client_payload":{"pr_number":$pr_number,"pr_sha":$pr_sha,"pr_branch":$pr_branch,"comment_number":$comment_number}}' ) From dfb3da26a92bdc2c2d147b7098d34f562863a8de Mon Sep 17 00:00:00 2001 From: Shreyash Chauhan <87440427+shreyash2002@users.noreply.github.com> Date: Mon, 24 Jun 2024 12:01:09 +0530 Subject: [PATCH 2/4] [ci] enforced shellcheck checks in .ci/set_commit_status.sh (#6498) - Fixed SC2086 (info): Double quote to prevent globbing and word splitting. --- .ci/set_commit_status.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/set_commit_status.sh b/.ci/set_commit_status.sh index c5181614496c..32c37337ccca 100755 --- a/.ci/set_commit_status.sh +++ b/.ci/set_commit_status.sh @@ -39,7 +39,7 @@ sha=$3 data=$( jq -n \ - --arg state $status \ + --arg state "$status" \ --arg url "${GITHUB_SERVER_URL}/microsoft/LightGBM/actions/runs/${GITHUB_RUN_ID}" \ --arg name "$name" \ '{"state":$state,"target_url":$url,"context":$name}' From 6ee5286d27a00717fe0c03a4dff38590630508ef Mon Sep 17 00:00:00 2001 From: Shreyash Chauhan <87440427+shreyash2002@users.noreply.github.com> Date: Mon, 24 Jun 2024 12:06:57 +0530 Subject: [PATCH 3/4] [ci] enforced shellcheck checks in .ci/install-clang-devel.sh issue(#6498) - fixed SC2086 (info): Double quote to prevent globbing and word splitting. --- .ci/install-clang-devel.sh | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/.ci/install-clang-devel.sh b/.ci/install-clang-devel.sh index 3556fccaebd8..152bd9d177b5 100755 --- a/.ci/install-clang-devel.sh +++ b/.ci/install-clang-devel.sh @@ -32,26 +32,26 @@ add-apt-repository -y "deb-src http://apt.llvm.org/unstable/ llvm-toolchain-${CL apt-get update -y apt-get install -y --no-install-recommends \ - clang-${CLANG_VERSION} \ - clangd-${CLANG_VERSION} \ - clang-format-${CLANG_VERSION} \ - clang-tidy-${CLANG_VERSION} \ - clang-tools-${CLANG_VERSION} \ - lldb-${CLANG_VERSION} \ - lld-${CLANG_VERSION} \ - llvm-${CLANG_VERSION}-dev \ - llvm-${CLANG_VERSION}-tools \ - libomp-${CLANG_VERSION}-dev \ - libc++-${CLANG_VERSION}-dev \ - libc++abi-${CLANG_VERSION}-dev \ - libclang-common-${CLANG_VERSION}-dev \ - libclang-${CLANG_VERSION}-dev \ - libclang-cpp${CLANG_VERSION}-dev \ - libunwind-${CLANG_VERSION}-dev + clang-"${CLANG_VERSION}" \ + clangd-"${CLANG_VERSION}" \ + clang-format-"${CLANG_VERSION}" \ + clang-tidy-"${CLANG_VERSION}" \ + clang-tools-"${CLANG_VERSION}" \ + lldb-"${CLANG_VERSION}" \ + lld-"${CLANG_VERSION}" \ + llvm-"${CLANG_VERSION}"-dev \ + llvm-"${CLANG_VERSION}"-tools \ + libomp-"${CLANG_VERSION}"-dev \ + libc++-"${CLANG_VERSION}"-dev \ + libc++abi-"${CLANG_VERSION}"-dev \ + libclang-common-"${CLANG_VERSION}"-dev \ + libclang-"${CLANG_VERSION}"-dev \ + libclang-cpp"${CLANG_VERSION}"-dev \ + libunwind-"${CLANG_VERSION}"-dev # overwriting the stuff in /usr/bin is simpler and more reliable than # updating PATH, LD_LIBRARY_PATH, etc. -cp --remove-destination /usr/lib/llvm-${CLANG_VERSION}/bin/* /usr/bin/ +cp --remove-destination /usr/lib/llvm-"${CLANG_VERSION}"/bin/* /usr/bin/ # per https://www.stats.ox.ac.uk/pub/bdr/Rconfig/r-devel-linux-x86_64-fedora-clang # From 1978e19eaacbc1822dec39f9cb6f68e1dd8ccb63 Mon Sep 17 00:00:00 2001 From: Shreyash Chauhan <87440427+shreyash2002@users.noreply.github.com> Date: Tue, 25 Jun 2024 04:37:18 +0530 Subject: [PATCH 4/4] fix shellcheck errors in .ci/install-clang-devel.sh - Used double quotes around entire word as suggested - https://github.com/microsoft/LightGBM/issues/6498 --- .ci/install-clang-devel.sh | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/.ci/install-clang-devel.sh b/.ci/install-clang-devel.sh index 152bd9d177b5..49248475bd66 100755 --- a/.ci/install-clang-devel.sh +++ b/.ci/install-clang-devel.sh @@ -32,22 +32,22 @@ add-apt-repository -y "deb-src http://apt.llvm.org/unstable/ llvm-toolchain-${CL apt-get update -y apt-get install -y --no-install-recommends \ - clang-"${CLANG_VERSION}" \ - clangd-"${CLANG_VERSION}" \ - clang-format-"${CLANG_VERSION}" \ - clang-tidy-"${CLANG_VERSION}" \ - clang-tools-"${CLANG_VERSION}" \ - lldb-"${CLANG_VERSION}" \ - lld-"${CLANG_VERSION}" \ - llvm-"${CLANG_VERSION}"-dev \ - llvm-"${CLANG_VERSION}"-tools \ - libomp-"${CLANG_VERSION}"-dev \ - libc++-"${CLANG_VERSION}"-dev \ - libc++abi-"${CLANG_VERSION}"-dev \ - libclang-common-"${CLANG_VERSION}"-dev \ - libclang-"${CLANG_VERSION}"-dev \ - libclang-cpp"${CLANG_VERSION}"-dev \ - libunwind-"${CLANG_VERSION}"-dev + "clang-${CLANG_VERSION}" \ + "clangd-${CLANG_VERSION}" \ + "clang-format-${CLANG_VERSION}" \ + "clang-tidy-${CLANG_VERSION}" \ + "clang-tools-${CLANG_VERSION}" \ + "lldb-${CLANG_VERSION}" \ + "lld-${CLANG_VERSION}" \ + "llvm-${CLANG_VERSION}"-dev \ + "llvm-${CLANG_VERSION}"-tools \ + "libomp-${CLANG_VERSION}"-dev \ + "libc++-${CLANG_VERSION}"-dev \ + "libc++abi-${CLANG_VERSION}"-dev \ + "libclang-common-${CLANG_VERSION}"-dev \ + "libclang-${CLANG_VERSION}"-dev \ + "libclang-cpp${CLANG_VERSION}"-dev \ + "libunwind-${CLANG_VERSION}"-dev # overwriting the stuff in /usr/bin is simpler and more reliable than # updating PATH, LD_LIBRARY_PATH, etc.