Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Error length of the array in example code #646

Open
weucode opened this issue Dec 2, 2022 · 5 comments · May be fixed by #664
Open

Error length of the array in example code #646

weucode opened this issue Dec 2, 2022 · 5 comments · May be fixed by #664
Labels
Area-Documentation Issue relates to API documentation comments, READMEs, or other documentation in this repo. Kind-Bug Something isn't working Pkg-Chemistry Issue relates to the Microsoft.Quantum.Chemistry.* packages.

Comments

@weucode
Copy link
Contributor

weucode commented Dec 2, 2022

The correct code should be:

let bitString = _ComputeJordanWignerBitString(7, [0,1,2,6]) ;

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
@msoeken msoeken added Kind-Bug Something isn't working Area-Documentation Issue relates to API documentation comments, READMEs, or other documentation in this repo. Pkg-Chemistry Issue relates to the Microsoft.Quantum.Chemistry.* packages. labels Dec 4, 2022
@msoeken
Copy link
Member

msoeken commented Dec 4, 2022

Thanks for reporting this issue @weucode. Would you be interested in providing a PR to fix it? I am happy to help if there are questions.

@weucode
Copy link
Contributor Author

weucode commented Dec 11, 2022

I am sorry to reply so late. By the way, I am new to this job, so please suggest which repository I should clone and edit. Dose
MicrosoftDocs/quantum-api is a proper one?

@msoeken
Copy link
Member

msoeken commented Dec 14, 2022

Hi @weucode, no problem. The code is in this repository and you can find it here:

QuantumLibraries/Chemistry/src/Runtime/JordanWigner/JordanWignerClusterOperatorEvolutionSet.qs

Line 27 in 6f41efc

/// let bitString = _ComputeJordanWignerBitString(6, [0,1,2,6]) ;

@ihristova11
Copy link
Contributor

Hi @msoeken, I see this is still not fixed and I am happy to submit a PR if it is ok with you

@msoeken
Copy link
Member

msoeken commented Mar 15, 2023

Hi @ihristova11, that would be great!

@ihristova11 ihristova11 linked a pull request Mar 15, 2023 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area-Documentation Issue relates to API documentation comments, READMEs, or other documentation in this repo. Kind-Bug Something isn't working Pkg-Chemistry Issue relates to the Microsoft.Quantum.Chemistry.* packages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example of function _ComputeJordanWignerBitString ihristova11/QuantumLibraries
3 participants
@msoeken @ihristova11 @weucode