Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationOptions is missing actions option #1725

Open
TheNoim opened this issue May 13, 2024 · 5 comments
Open

NotificationOptions is missing actions option #1725

TheNoim opened this issue May 13, 2024 · 5 comments

Comments

@TheNoim
Copy link

TheNoim commented May 13, 2024

Hey,

I noticed that the NotificationOptions definition doesn't include the actions option. This is the current definition: dom.generated.d.ts and serviceworker.generated.d.ts

Here is the relevant mdn link.

In addition, timestamp and renotify are also missing.

This might be an regression of #438, but I am not sure.

@HolgerJeromin
Copy link
Contributor

https://github.com/microsoft/TypeScript-DOM-lib-generator?tab=readme-ov-file#when-the-type-is-missing

If there is, see the browser compatibility section and check whether it's supported by two or more browser engines. (Note that Chromium-based browsers use the same browser engine and thus support from them counts as a single support.)

So your suggestion is missing Firefox or Safari support.

@benelliott
Copy link

As mentioned by @TheNoim, timestamp has been removed without any documentation on MDN suggesting lack of support.

@markusahrweileramcon
Copy link

markusahrweileramcon commented Jun 28, 2024

So your suggestion is missing Firefox or Safari support.

requireInteraction is included and has the same support as actions

@IgnisDa
Copy link

IgnisDa commented Sep 28, 2024

Is there any update on this?

@tappin-kr
Copy link

Looking for an update on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants