From 986359c44d93014f05aa8669c8970ec21a7a4585 Mon Sep 17 00:00:00 2001 From: Anton Gilgur Date: Tue, 18 Jul 2023 14:09:36 -0400 Subject: [PATCH 1/2] feat: add `package.json` options to Related - these influence how `moduleResolution` works, and so should be Related to it - and also Related to each other --- packages/tsconfig-reference/scripts/tsconfigRules.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/tsconfig-reference/scripts/tsconfigRules.ts b/packages/tsconfig-reference/scripts/tsconfigRules.ts index 9226cc1abea4..bc772c9a42dd 100644 --- a/packages/tsconfig-reference/scripts/tsconfigRules.ts +++ b/packages/tsconfig-reference/scripts/tsconfigRules.ts @@ -167,8 +167,11 @@ export const relatedTo: [AnOption, AnOption[]][] = [ ["declarationDir", ["declaration"]], ["emitDeclarationOnly", ["declaration"]], - ["moduleResolution", ["module"]], ["module", ["moduleResolution"]], + ["moduleResolution", ["module", "customConditions", "resolvePackageJsonExports", "resolvePackageJsonImports"]], + ["customConditions", ["moduleResolution", "resolvePackageJsonExports", "resolvePackageJsonImports"]], + ["resolvePackageJsonExports", ["moduleResolution", "customConditions", "resolvePackageJsonImports"]], + ["resolvePackageJsonImports", ["moduleResolution", "customConditions", "resolvePackageJsonExports"]], ["jsx", ["jsxFactory", "jsxFragmentFactory", "jsxImportSource"]], ["jsxFactory", ["jsx", "jsxFragmentFactory", "jsxImportSource"]], From e3a29c761a8d3e099b519aac7a2a7db52fa31dc6 Mon Sep 17 00:00:00 2001 From: Andrew Branch Date: Mon, 24 Jul 2023 13:48:29 -0700 Subject: [PATCH 2/2] Add more related options --- packages/tsconfig-reference/scripts/tsconfigRules.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/tsconfig-reference/scripts/tsconfigRules.ts b/packages/tsconfig-reference/scripts/tsconfigRules.ts index bc772c9a42dd..5d3f0b1e8cd2 100644 --- a/packages/tsconfig-reference/scripts/tsconfigRules.ts +++ b/packages/tsconfig-reference/scripts/tsconfigRules.ts @@ -167,8 +167,8 @@ export const relatedTo: [AnOption, AnOption[]][] = [ ["declarationDir", ["declaration"]], ["emitDeclarationOnly", ["declaration"]], - ["module", ["moduleResolution"]], - ["moduleResolution", ["module", "customConditions", "resolvePackageJsonExports", "resolvePackageJsonImports"]], + ["module", ["moduleResolution", "esModuleInterop", "allowImportingTsExtensions", "allowArbitraryExtensions", "resolveJsonModule"]], + ["moduleResolution", ["module", "paths", "baseUrl", "rootDirs", "moduleSuffixes", "customConditions", "resolvePackageJsonExports", "resolvePackageJsonImports"]], ["customConditions", ["moduleResolution", "resolvePackageJsonExports", "resolvePackageJsonImports"]], ["resolvePackageJsonExports", ["moduleResolution", "customConditions", "resolvePackageJsonImports"]], ["resolvePackageJsonImports", ["moduleResolution", "customConditions", "resolvePackageJsonExports"]],