Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: ProjFS regression with buffer resizing #1696

Open
2 of 4 tasks
derrickstolee opened this issue Oct 14, 2020 · 3 comments
Open
2 of 4 tasks

Tracking: ProjFS regression with buffer resizing #1696

derrickstolee opened this issue Oct 14, 2020 · 3 comments
Labels
affects: engineering Keeping the engineering system healthy type: test-reliability Issues that contribute to test failures

Comments

@derrickstolee
Copy link
Contributor

derrickstolee commented Oct 14, 2020

While working on the GIt 2.29.0 update, we noticed that projections were failing to match vanilla Git when it came to the GVFlt_MoveFileTests/LongFileName folder. The root cause is that ProjFS updated recently in response to a security bug, but that fix included a change to how it handles resizing filename buffers.

With the help of @wilbaker and @cgallred, we discovered the root cause, and the ProjFS team is working on a fix.

In order to get us unblocked, we need to stop testing this scenario until ProjFS ships to the Azure Pipelines build machines.

  1. Remove the GVFlt_MoveFileTests/LongFileName folder in the test repo (using new branches FunctionalTests/20201014*)
  2. Point VFS for Git functional tests to that branch, and ignore any tests that care about that folder. (Fix functional tests to skip around ProjFS issue #1697)
  3. Periodically check if we can revert that change to the functional tests.
  4. Revert the test changes.
@derrickstolee derrickstolee added type: test-reliability Issues that contribute to test failures affects: engineering Keeping the engineering system healthy labels Oct 14, 2020
@derrickstolee derrickstolee self-assigned this Oct 14, 2020
derrickstolee added a commit that referenced this issue Oct 15, 2020
…issue

See #1696 for the tracking issue.

This PR intends to get our functional tests green again so we can have some confidence in the Git 2.29.0 update in #1694.
@iamhardikat11
Copy link

I am Novice Open Source Programmer, looking contribute to this Repository, can you please describer more on this issue?

@derrickstolee
Copy link
Contributor Author

Hi @iamhardikat11: the cause of this bug was in a low-level driver included in Windows (and is not open source). The only action here is to revert #1697, assuming that the GitHub Actions workflow runners have updated to a version of Windows with the fix.

Overall, this repository is in maintenance mode, so I don't think it's a good fit for learning about open source contributions.

@iamhardikat11
Copy link

Ok Thank You.

@derrickstolee derrickstolee removed their assignment Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: engineering Keeping the engineering system healthy type: test-reliability Issues that contribute to test failures
Projects
None yet
Development

No branches or pull requests

2 participants