Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: move CopyButton lower #1533

Open
Jay-o-Way opened this issue May 5, 2024 · 6 comments
Open

Request: move CopyButton lower #1533

Jay-o-Way opened this issue May 5, 2024 · 6 comments
Labels
design Issues with design/layout

Comments

@Jay-o-Way
Copy link
Contributor

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

Currently, the CopyButton is usually displayed on one line, next to the related value. However, for the colors, it's displayed in the top-right corner, while the value is on the bottom. It would be nice if the CopyButton sticks immediately to the right of the value everywhere.

Screenshots

image

Windows version

Windows 11 23H2 (22631)

Additional context

Check validity / status for this message.
image

@Jay-o-Way Jay-o-Way changed the title Request: move CpoyButton lower Request: move CopyButton lower May 5, 2024
@Jay-o-Way
Copy link
Contributor Author

Jay-o-Way commented May 5, 2024

I can create a PR for this 💪
image

@niels9001
Copy link
Contributor

Understand the reasoning! But we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

@karkarl
Copy link
Collaborator

karkarl commented May 16, 2024

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

@karkarl karkarl added design Issues with design/layout and removed needs-triage labels May 16, 2024
@niels9001
Copy link
Contributor

Is there a reason why the copy buttons don't only show up on hover? That might solve the issue with longer brush names. I remember reading a Microsoft design guideline that discourages it.

That would require adding keyboarding support as well :(

@Jay-o-Way
Copy link
Contributor Author

we moved it to the top because the brush names tend to be much longer than the titles. As a result, brush names are either clipped or wrapped, both not great.

That argument is not valid in every case:
image

@Jay-o-Way
Copy link
Contributor Author

@karkarl can you confirm if the message is outdated and can be removed?

This brush might not (yet) be available in WinUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Issues with design/layout
Projects
None yet
Development

No branches or pull requests

3 participants