Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider creating separate Host and Client NuGet packages #42

Closed
jkonecki opened this issue Feb 25, 2017 · 6 comments
Closed

Consider creating separate Host and Client NuGet packages #42

jkonecki opened this issue Feb 25, 2017 · 6 comments

Comments

@jkonecki
Copy link
Contributor

The new advanced client features (monitored deployments, health checks, graceful shutdown) require yams applications to reference YAMS NuGet package to use YAMS client.

Currently YAMS NuGet package contains several dependencies that are not needed by the client, 'polluting' package dependencied of the client application. This also increases the risk of conflicts between versions required by YAMS and the application.

What is more, Client NuGet package will probably evolve slover than the host so it can be versioned separatelly.

I think a separate NuGet packages for Host and Client will minimize the impact on using advanced YAMS features in individual applications.

@nehmebilal
Copy link
Collaborator

Hi @jkonecki,

I totally agree and was considering it as soon as I added the Yams client Api but got a bit lazy and postponed it. I'm actually considering three NuGet packages at this point:

  • Etg.Yams.Core: Yams without storage providers (independent of Blob storage).
  • Etg.Yams: The current ready to go server side package.
  • Etg.Yams.Client: The Yams client.

@nehmebilal
Copy link
Collaborator

Can this wait until the next release that would hopefully include the load balancer feature described in #43 ?

@jkonecki
Copy link
Contributor Author

I see no problem with waiting.

@nehmebilal
Copy link
Collaborator

nehmebilal commented Oct 23, 2017

Done. The NuGet is Etg.Yams.Client.

@jkonecki
Copy link
Contributor Author

Finally, the answer to Life, Universe and Everything! But which package do I need to install to find the question? ;-)

@nehmebilal
Copy link
Collaborator

:) Etg.Yams for deploying Yams and Etg.Yams.Client for apps that use health features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants