From 3353c5184cc03965958b3a7e9ec074a3a605f474 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Vercaemst?= Date: Fri, 24 Nov 2023 15:16:38 +0100 Subject: [PATCH] Fix formatting issues and syntax errors in code --- .../docs/BestPractices/blank-lines/index.md | 4 ++-- .../patterns/data-migration-facade/index.md | 6 +++--- content/docs/patterns/command-queue/index.md | 18 +++++++++--------- .../patterns/event-bridge-pattern/index.md | 12 ++++++------ .../patterns/generic-method-pattern/index.md | 14 +++++++------- .../patterns/template-method-pattern/index.md | 10 +++++----- 6 files changed, 32 insertions(+), 32 deletions(-) diff --git a/content/docs/BestPractices/blank-lines/index.md b/content/docs/BestPractices/blank-lines/index.md index 6c5a0303f..7f1b8efe2 100644 --- a/content/docs/BestPractices/blank-lines/index.md +++ b/content/docs/BestPractices/blank-lines/index.md @@ -17,7 +17,7 @@ Do not use blank lines: ### Bad code ```al -procedure MATRIX_OnDrillDown(MATRIX_ColumnOrdinal: Integer); +procedure MATRIX_OnDrillDown(MATRIX_ColumnOrdinal: Integer) begin SetupDrillDownCol(MATRIX_ColumnOrdinal); @@ -29,7 +29,7 @@ end; ### Good code ```al -procedure MATRIX_OnDrillDown(MATRIX_ColumnOrdinal: Integer); +procedure MATRIX_OnDrillDown(MATRIX_ColumnOrdinal: Integer) begin SetupDrillDownCol(MATRIX_ColumnOrdinal); DrillDown(false, ValueType); diff --git a/content/docs/NAVPatterns/patterns/data-migration-facade/index.md b/content/docs/NAVPatterns/patterns/data-migration-facade/index.md index 874f937bc..e4e5aa4ef 100644 --- a/content/docs/NAVPatterns/patterns/data-migration-facade/index.md +++ b/content/docs/NAVPatterns/patterns/data-migration-facade/index.md @@ -108,7 +108,7 @@ begin end; end; -procedure MigrateItemUnitOfMeasure(ItemDataMigrationFacade : Codeunit "Item Data Migration Facade"; ItemJson : Text); +procedure MigrateItemUnitOfMeasure(ItemDataMigrationFacade : Codeunit "Item Data Migration Facade"; ItemJson : Text) var MyUnitCodeStagingTable: Record "My Unit Code Staging Table"; DataMigrationStatusFacade: Codeunit "Data Migration Status Facade"; @@ -154,7 +154,7 @@ _Figure 3: Simplified sequence diagram of the data migration with staging tables Below is a simplified example showing how to create an item: ```al [EventSubscriber(ObjectType::Codeunit, Codeunit::"Item Data Migration Facade", 'OnMigrateItem', '', true, true)] -procedure OnMigrateItem(VAR Sender : Codeunit "Item Data Migration Facade";RecordIdToMigrate : RecordId); +procedure OnMigrateItem(VAR Sender : Codeunit "Item Data Migration Facade";RecordIdToMigrate : RecordId) var MyItemStagingTable : Record "My Item Staging Table"; begin @@ -186,7 +186,7 @@ Below is another example showing how to use additional events to set fields that ```al [EventSubscriber(ObjectType::Codeunit, Codeunit::"Item Data Migration Facade", 'OnMigrateItemUnitOfMeasure', '', true, true)] -procedure OnMigrateItemUnitOfMeasure(VAR Sender : Codeunit "Item Data Migration Facade";RecordIdToMigrate : RecordId); +procedure OnMigrateItemUnitOfMeasure(VAR Sender : Codeunit "Item Data Migration Facade";RecordIdToMigrate : RecordId) var MyItemStagingTable : Record "My Item Staging Table"; MyUnitCodeStagingTable : Record "My Unit Code Staging Table"; diff --git a/content/docs/patterns/command-queue/index.md b/content/docs/patterns/command-queue/index.md index 036d080fc..a414765f5 100644 --- a/content/docs/patterns/command-queue/index.md +++ b/content/docs/patterns/command-queue/index.md @@ -26,7 +26,7 @@ First the command interface, it only has one procedure to execute the command ```al interface ICommand { - procedure Execute(); + procedure Execute() } ``` @@ -52,7 +52,7 @@ codeunit 50100 "Queue" count += 1; end; - procedure Pop() value: Interface ICommand; + procedure Pop() value: Interface ICommand begin if count > 0 then begin value := first.GetValue(); @@ -78,22 +78,22 @@ codeunit 50100 "Queue" codeunit 50102 "QueueEntry" { - procedure SetValue(var v: Interface ICommand); + procedure SetValue(var v: Interface ICommand) begin value := v; end; - procedure GetValue(): Interface ICommand; + procedure GetValue(): Interface ICommand begin exit(value); end; - procedure GetNextEntry(): Codeunit QueueEntry; + procedure GetNextEntry(): Codeunit QueueEntry begin exit(NextEntry); end; - procedure SetNextEntry(var Entry: Codeunit QueueEntry); + procedure SetNextEntry(var Entry: Codeunit QueueEntry) begin NextEntry := Entry; end; @@ -136,7 +136,7 @@ codeunit 50104 "SalesOrderPostCommander" implements ICommand codeunit 50103 "MessageCommander" implements ICommand { - procedure SetText(value: Text); + procedure SetText(value: Text) begin t := value; end; @@ -185,7 +185,7 @@ codeunit 50105 PatchPostQueue // Filter Sales Orders here end; - local procedure AddMessageToQueue(message : Text); + local procedure AddMessageToQueue(message : Text) var t: Codeunit MessageCommander; object: Interface ICommand; @@ -195,7 +195,7 @@ codeunit 50105 PatchPostQueue queue.Push(object); end; - local procedure AddSalesOrderToQueue(No : Text); + local procedure AddSalesOrderToQueue(No : Text) var SaleOrderCommander: Codeunit SalesOrderPostCommander; object: Interface ICommand; diff --git a/content/docs/patterns/event-bridge-pattern/index.md b/content/docs/patterns/event-bridge-pattern/index.md index 7fde06834..e05deadc2 100644 --- a/content/docs/patterns/event-bridge-pattern/index.md +++ b/content/docs/patterns/event-bridge-pattern/index.md @@ -20,8 +20,8 @@ Like in this example, we have an interface, to implement different ways for gett ```AL interface "IScale" { - procedure GetWeight(): Decimal; - procedure Tare(); + procedure GetWeight(): Decimal + procedure Tare() } ``` @@ -35,13 +35,13 @@ So, if we would implement it like this, it isn't really extensible, as a differe ```AL codeunit 50407 "Scale Wrong" implements IScale { - procedure GetWeight() Result: Decimal; + procedure GetWeight() Result: Decimal begin //TODO: Implement Bar GetWeight OnAfterGetWeight(Result); end; - procedure Tare(); + procedure Tare() begin //TODO: Implement Bar Tare OnAfterTare(); @@ -86,13 +86,13 @@ codeunit 50405 "Scale Bar" implements IScale var IScaleTriggers: Codeunit "IScale Triggers"; - procedure GetWeight() Result: Decimal; + procedure GetWeight() Result: Decimal begin //TODO: Implement Bar GetWeight IScaleTriggers.OnAfterGetWeight(Result); end; - procedure Tare(); + procedure Tare() begin //TODO: Implement Bar Tare IScaleTriggers.OnAfterTare(); diff --git a/content/docs/patterns/generic-method-pattern/index.md b/content/docs/patterns/generic-method-pattern/index.md index db8808921..a16e2b645 100644 --- a/content/docs/patterns/generic-method-pattern/index.md +++ b/content/docs/patterns/generic-method-pattern/index.md @@ -61,7 +61,7 @@ codeunit 53100 "WLD BlockCustomer Meth" AcknowledgeBlockCustomer(HideDialog) end; - local procedure DoBlockCustomer(var Cust: Record Customer; IsHandled: Boolean); + local procedure DoBlockCustomer(var Cust: Record Customer; IsHandled: Boolean) begin if IsHandled then exit; @@ -93,12 +93,12 @@ codeunit 53100 "WLD BlockCustomer Meth" end; [IntegrationEvent(false, false)] - local procedure OnBeforeBlockCustomer(var Cust: Record Customer; var IsHandled: Boolean); + local procedure OnBeforeBlockCustomer(var Cust: Record Customer; var IsHandled: Boolean) begin end; [IntegrationEvent(false, false)] - local procedure OnAfterBlockCustomer(var Cust: Record Customer); + local procedure OnAfterBlockCustomer(var Cust: Record Customer) begin end; } @@ -181,12 +181,12 @@ codeunit 53100 "WLD BlockCustomer Meth" end; ... [IntegrationEvent(false, false)] - local procedure OnBeforeBlockCustomer(var Cust: Record Customer; var IsHandled: Boolean); + local procedure OnBeforeBlockCustomer(var Cust: Record Customer; var IsHandled: Boolean) begin end; [IntegrationEvent(false, false)] - local procedure OnAfterBlockCustomer(var Cust: Record Customer); + local procedure OnAfterBlockCustomer(var Cust: Record Customer) begin end; } @@ -200,7 +200,7 @@ The relevant part is: ```AL codeunit 53100 "WLD BlockCustomer Meth" { - internal procedure BlockCustomer(var Cust: Record Customer; HideDialog: Boolean); + internal procedure BlockCustomer(var Cust: Record Customer; HideDialog: Boolean) var IsHandled: Boolean; begin @@ -209,7 +209,7 @@ codeunit 53100 "WLD BlockCustomer Meth" ... end; - local procedure DoBlockCustomer(var Cust: Record Customer; IsHandled: Boolean); + local procedure DoBlockCustomer(var Cust: Record Customer; IsHandled: Boolean) begin if IsHandled then exit; diff --git a/content/docs/patterns/template-method-pattern/index.md b/content/docs/patterns/template-method-pattern/index.md index 81eab9c36..95570ecdd 100644 --- a/content/docs/patterns/template-method-pattern/index.md +++ b/content/docs/patterns/template-method-pattern/index.md @@ -75,11 +75,11 @@ As the second part we need an interface for the export functions ```al interface IDataExport { - procedure CheckData(): Boolean; - procedure GetLinesToExport(): Boolean; - procedure ExportLine(); - procedure NextLine(): Boolean; - procedure Finish(); + procedure CheckData(): Boolean + procedure GetLinesToExport(): Boolean + procedure ExportLine() + procedure NextLine(): Boolean + procedure Finish() } ```