From 5139251066514f153731dab1d391fb12a8efee0b Mon Sep 17 00:00:00 2001 From: Tanmay Fadnavis Date: Tue, 3 Oct 2023 09:22:46 -0700 Subject: [PATCH] It works --- src/Agent.Plugins/Artifact/PipelineArtifactConstants.cs | 1 + .../Blob/DedupManifestArtifactClientFactory.cs | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Agent.Plugins/Artifact/PipelineArtifactConstants.cs b/src/Agent.Plugins/Artifact/PipelineArtifactConstants.cs index 407ddb521b..f0cd3908ce 100644 --- a/src/Agent.Plugins/Artifact/PipelineArtifactConstants.cs +++ b/src/Agent.Plugins/Artifact/PipelineArtifactConstants.cs @@ -3,6 +3,7 @@ namespace Agent.Plugins { + // Use PipelineArtifactContants.cs from ADO, once the latest libs are available. public class PipelineArtifactConstants { public const string AzurePipelinesAgent = "AzurePipelinesAgent"; diff --git a/src/Microsoft.VisualStudio.Services.Agent/Blob/DedupManifestArtifactClientFactory.cs b/src/Microsoft.VisualStudio.Services.Agent/Blob/DedupManifestArtifactClientFactory.cs index 88d6dc6114..cf7cfde0c4 100644 --- a/src/Microsoft.VisualStudio.Services.Agent/Blob/DedupManifestArtifactClientFactory.cs +++ b/src/Microsoft.VisualStudio.Services.Agent/Blob/DedupManifestArtifactClientFactory.cs @@ -145,6 +145,7 @@ private DedupManifestArtifactClientFactory() } traceOutput($"Max dedup parallelism: {maxParallelism}"); + traceOutput($"DomainId: {domainId}"); ArtifactHttpClientFactory factory = new ArtifactHttpClientFactory( connection.Credentials, @@ -176,14 +177,13 @@ private DedupManifestArtifactClientFactory() }); var telemetry = new BlobStoreClientTelemetry(tracer, dedupStoreHttpClient.BaseAddress); - traceOutput($"Hashtype: {this.HashType.Value}"); - this.HashType = GetClientHashType(clientSettings, context, tracer); if (this.HashType == BuildXL.Cache.ContentStore.Hashing.HashType.Dedup1024K) { dedupStoreHttpClient.RecommendedChunkCountPerCall = 10; // This is to workaround IIS limit - https://learn.microsoft.com/en-us/iis/configuration/system.webserver/security/requestfiltering/requestlimits/ } + traceOutput($"Hashtype: {this.HashType.Value}"); var dedupClient = new DedupStoreClientWithDataport(dedupStoreHttpClient, new DedupStoreClientContext(maxParallelism), this.HashType.Value); return (new DedupManifestArtifactClient(telemetry, dedupClient, tracer), telemetry);