Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement]: Add localImage option for job containers #5014

Open
npalmius opened this issue Oct 10, 2024 · 1 comment
Open

[enhancement]: Add localImage option for job containers #5014

npalmius opened this issue Oct 10, 2024 · 1 comment

Comments

@npalmius
Copy link

npalmius commented Oct 10, 2024

Describe your feature request here

When specifying a container in a resource, (e.g. resources.containers.container) there is a localImage option to use locally cached images rather than pulling from the repository (we are using self-hosted agents, so we pull the images that we need locally when building the agent).

However, we are using a lot of nested templates in our setup, so we define the container directly in the job (e.g. using a jobs.job.container: image definition).

This definition does not have all of the options from the resources.containers.container definition, and in particular the localImage option.

Would it be possible to add the ability to specify the localImage option in job container objects?

Note that trying to specify localImage for a jobs.job.container results in the following error:

(Line: 52, Col: 9): Unexpected value

@vmapetr
Copy link
Contributor

vmapetr commented Dec 3, 2024

Hi @npalmius, thank you for reporting this issue!
Could you please share more details?
What value do you use for the localImage? Please consider that this is boolean parameter which can take only true or false value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants