Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hcibox deployment experience - small improvements #2395

Merged
merged 10 commits into from
Feb 7, 2024
Merged

Hcibox deployment experience - small improvements #2395

merged 10 commits into from
Feb 7, 2024

Conversation

dkirby-ms
Copy link
Contributor

No description provided.

@dkirby-ms dkirby-ms marked this pull request as ready for review February 3, 2024 13:24
@dkirby-ms
Copy link
Contributor Author

dkirby-ms commented Feb 3, 2024 •
edited
Loading

closes #2394 #2396

likamrat
likamrat approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkirby-ms dkirby-ms marked this pull request as draft February 6, 2024 00:23
@dkirby-ms
Copy link
Contributor Author

Reverting this to draft to include another small fix

This was linked to issues Feb 6, 2024
HCIBox: azd preprovisioning can error out due to older Az.Accounts module. #2394
Closed
Answer files generated by New-HCIBoxCluster.ps1 should use base64 encoding #2396
Closed
@dkirby-ms dkirby-ms added the HCIBox Jumpstart HCIBox related label Feb 6, 2024
@dkirby-ms dkirby-ms added this to the February 2024 milestone Feb 6, 2024
@dkirby-ms dkirby-ms marked this pull request as ready for review February 6, 2024 23:12
likamrat
likamrat approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@likamrat likamrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkirby-ms dkirby-ms changed the title Hcibox preprovisioning small improvements Hcibox deployment experience - small improvements Feb 7, 2024
@dkirby-ms dkirby-ms merged commit ef46bc4 into microsoft:main Feb 7, 2024
1 check passed
@dkirby-ms dkirby-ms deleted the hcibox_patch branch February 14, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likamrat likamrat likamrat approved these changes

Assignees
No one assigned
Labels
HCIBox Jumpstart HCIBox related
Projects
Azure Arc Jumpstart
Status: Done
Milestone
February 2024
2 participants
@dkirby-ms @likamrat