Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebpfapi.dll should not depend on usersim.dll #2756

Closed
Alan-Jowett opened this issue Aug 15, 2023 · 3 comments · Fixed by #2783
Closed

ebpfapi.dll should not depend on usersim.dll #2756

Alan-Jowett opened this issue Aug 15, 2023 · 3 comments · Fixed by #2783
Assignees
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Milestone

Comments

@Alan-Jowett
Copy link
Member

Non-test programs using eBPF for Windows should not pull in usersim.dll

@dthaler
Copy link
Collaborator

dthaler commented Aug 15, 2023

See issue #2677. Currently usersim.dll includes some things that could be user-mode runtime related, and those parts would be needed for some non-test components. I was planning on handling things like export_program_info.exe as part of that work. For example, a couple places in the code have:

TODO(#2677): export_program_info.exe temporarily requires usersim.dll

We could factor usersim.dll into two binaries in the same repo or more likely move some to another repo like cxplat.

@saxena-anurag
Copy link
Contributor

If ebpfapi.dll depends on usersim.dll, it will require one more user mode binary to be installed. It can probably also increase load time.

@dthaler
Copy link
Collaborator

dthaler commented Aug 15, 2023

framework.h already has this:

// TODO(#2677): remove the following include, which should be private to usersim.dll.
#include "..\..\..\external\usersim\src\framework.h"

which I think is what this issue needs to do.

@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Aug 18, 2023
@dthaler dthaler self-assigned this Aug 21, 2023
@dthaler dthaler added this to the 2308 milestone Aug 21, 2023
@dthaler dthaler added the triaged Discussed in a triage meeting label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants