Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release instructions with regenerate SPGO data step #3986

Open
Alan-Jowett opened this issue Nov 6, 2024 · 0 comments
Open

Update release instructions with regenerate SPGO data step #3986

Alan-Jowett opened this issue Nov 6, 2024 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation P2 triaged Discussed in a triage meeting
Milestone

Comments

@Alan-Jowett
Copy link
Member

SPGO data makes a massive difference in the BPF performance benchmarks.

Before SPGO:

C:\Users\Administrator\Desktop\bpf_performance>Release\bpf_performance_runner.exe -i tests.yml -e .sys -t "bpf_tail_call" -c 100000000
Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns),CPU 1 Duration (ns),CPU 2 Duration (ns),CPU 3 Duration (ns),CPU 4 Duration (ns),CPU 5 Duration (ns),CPU 6 Duration (ns),CPU 7 Duration (ns)
2024-11-06T17:45:06-0800,bpf_tail_call,117,114,120,118,117,117,121,119,111

After SPGO:

C:\Users\Administrator\Desktop\bpf_performance>Release\bpf_performance_runner.exe -i tests.yml -e .sys -t "bpf_tail_call" -c 100000000
Timestamp,Test,Average Duration (ns),CPU 0 Duration (ns),CPU 1 Duration (ns),CPU 2 Duration (ns),CPU 3 Duration (ns),CPU 4 Duration (ns),CPU 5 Duration (ns),CPU 6 Duration (ns),CPU 7 Duration (ns)
2024-11-06T17:30:28-0800,bpf_tail_call,60,62,60,58,57,60,60,63,65

But SPGO counts can quickly become stale, resulting in fairly large performance regressions.

@saxena-anurag saxena-anurag self-assigned this Nov 6, 2024
@dthaler dthaler added the documentation Improvements or additions to documentation label Nov 11, 2024
@shankarseal shankarseal added the P2 label Nov 11, 2024
@shankarseal shankarseal added this to the 2411 milestone Nov 11, 2024
@shankarseal shankarseal added the triaged Discussed in a triage meeting label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation P2 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

4 participants