Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory.Build.Props uses %(AdditionalOptions) instead of $(AdditionalOptions) #3992

Open
Alan-Jowett opened this issue Nov 9, 2024 · 2 comments · May be fixed by #3989
Open

Directory.Build.Props uses %(AdditionalOptions) instead of $(AdditionalOptions) #3992

Alan-Jowett opened this issue Nov 9, 2024 · 2 comments · May be fixed by #3989
Assignees
@Alan-Jowett @shankarseal
Labels
ci/cd Issue is specific to CI/CD cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Milestone
2411

Comments

@Alan-Jowett
Copy link
Member

When expanding additional options, MSBuild only does replacement for $(AdditionalOptions) and not %(AdditionalOptions), so as a result subsequent additional options don't inherit correctly.
@dthaler
Copy link
Collaborator

dthaler commented Nov 11, 2024

Fixed by #3991?

@dthaler dthaler added the cleanup Affects API usability or code maintainability but not correctness or applicability label Nov 11, 2024
@shankarseal shankarseal self-assigned this Nov 11, 2024
@shankarseal
Copy link
Collaborator

Fixed by #3991?

Indeed this PR should fix this issue.

@shankarseal shankarseal added triaged Discussed in a triage meeting ci/cd Issue is specific to CI/CD labels Nov 11, 2024
@shankarseal shankarseal added this to the 2411 milestone Nov 11, 2024
@shankarseal shankarseal linked a pull request Nov 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alan-Jowett Alan-Jowett

@shankarseal shankarseal

Labels
ci/cd Issue is specific to CI/CD cleanup Affects API usability or code maintainability but not correctness or applicability triaged Discussed in a triage meeting
Projects
None yet
Milestone
2411
Development

Successfully merging a pull request may close this issue.

Fuzzing bug fixes shankarseal/ebpf-for-windows
3 participants
@dthaler @Alan-Jowett @shankarseal