Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-plugin: check for invalid selectors #306

Open
NotWoods opened this issue Jan 6, 2023 · 0 comments
Open

eslint-plugin: check for invalid selectors #306

NotWoods opened this issue Jan 6, 2023 · 0 comments
Labels
💅 enhancement New feature or request

Comments

@NotWoods
Copy link
Contributor

NotWoods commented Jan 6, 2023

This is also checked at runtime but it would be nice to have it in the linter for CI.

makeStyles({
  foo: {
    // invalid, should be '&.withClass'
    '.withClass': {}
  }
})

It might be useful to create a @griffel/validation package to share these checks between core and the eslint-plugin. That could also hold the set of invalid shorthand selectors.

@layershifter layershifter added the 💅 enhancement New feature or request label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💅 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants