Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcePaths no longer work after #354 #455

Open
puremourning opened this issue Nov 7, 2022 · 1 comment
Open

sourcePaths no longer work after #354 #455

puremourning opened this issue Nov 7, 2022 · 1 comment

Comments

@puremourning
Copy link

puremourning commented Nov 7, 2022

I submitted a detailed review on #354

Essentially it seems that user-specified sourcePaths are no longer used when resolving the filesystem path for a file in the stack trace after the above patch. The result is that we always return jdt:// paths which not all clients know how to handle.

It seems to me that we should always prefer filesystem paths (having applied user sourcePaths) over "internal" jdt:// paths.

@puremourning
Copy link
Author

One solution might be an option to ask the server to never return a .class file jdt:// path and always return from the sourcePaths or "unknown"

@puremourning puremourning changed the title sourcePaths no longer work after #890 sourcePaths no longer work after #354 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant