Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation failure #55

Open
JihaoXin opened this issue Aug 16, 2023 · 3 comments
Open

Compilation failure #55

JihaoXin opened this issue Aug 16, 2023 · 3 comments

Comments

@JihaoXin
Copy link
Contributor

I failed the build, with uint64_t undefined.
After #include <cstdint> in src/include/collectives.h it works.
Maybe there should be a better way.

../../include/collectives.h(18): error: identifier "uint64_t" is undefined
    uint64_t scalarArg;
    ^
1 error detected in the compilation of "custom_collective.cu".
make[2]: *** [/home/ubuntu/jihao/msccl/build/obj/collectives/device/Makefile.rules:2274: /home/ubuntu/jihao/msccl/build/obj/collectives/device/custom_collective_max_i64.o] Error 2
@JihaoXin JihaoXin changed the title Compilation fails Compilation failure Aug 16, 2023
@saeedmaleki
Copy link
Contributor

it really depends on the compiler you are using. But in general, I like your idea of including having the explicit include to avoid these kinds of issues. I will fix this in near future. Thanks for pointing it out!

@saeedmaleki
Copy link
Contributor

can you please raise a PR for this fix, @JihaoXin ?

@JihaoXin
Copy link
Contributor Author

Thank you Saeed, I've created the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants