Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Doubt about the Source Code of MSCCL #61

Open
ltrcc opened this issue Mar 30, 2024 · 1 comment
Open

A Doubt about the Source Code of MSCCL #61

ltrcc opened this issue Mar 30, 2024 · 1 comment

Comments

@ltrcc
Copy link

ltrcc commented Mar 30, 2024

I am currently studying the source code of MSCCL, I have some doubts about the count variable in this structure. What does it mean?

// TODO: compress this by a lot!
struct mscclTransfer {
  int16_t srcoffset;
  int16_t dstoffset;
  uint8_t srcbuffer; // follow MSCCL_THIS_INPUT/MSCCL_THIS_OUTPUT macros
  uint8_t dstbuffer; // follow MSCCL_THIS_INPUT/MSCCL_THIS_OUTPUT macros
  int16_t depencePointer; // index to the first dependence
  int16_t numDependences; // depencePointer+numDependences indicate the last dependence
  int8_t has_dependence;
  int16_t numReductions; // number of reductions with the same dst
  int16_t reductionPointer; // where the reduction starts
  uint8_t type;
  //--------------//
  uint8_t count; //
  //--------------//
};
@ltrcc
Copy link
Author

ltrcc commented Mar 30, 2024

#define MSCCL_MAX_NUM_ALGOS 4

if (mscclInfo->numberOfMSCCLAlgorithms == MSCCL_MAX_NUM_ALGOS){
      WARN("MSCCL: too many algorithms (%d) specified in environment variable MSCCL_XML_FILES. The rest will be ignored.", mscclInfo->numberOfMSCCLAlgorithms);
      break;
    }

Furthermore, why limit the number of algorithms?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant