Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Remove old scheduled jobs #173

Closed
1 task done
makubacki opened this issue Aug 15, 2023 · 1 comment
Closed
1 task done

[Bug]: Remove old scheduled jobs #173

makubacki opened this issue Aug 15, 2023 · 1 comment
Assignees
@Javagedes
Labels
type:bug Something isn't working urgency:low Little to no impact

Comments

@makubacki
Copy link
Member

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Old Mu branches have scheduled jobs that are regularly being built consuming unnecessary CI resources and bloating pipeline history.

Expected Behavior

Only N and N-1 Mu branches are built.

Steps To Reproduce

Review schedule builds in Project Mu pipelines - https://dev.azure.com/projectmu/mu/_build

Build Environment

N/A

Version Information

N/A

Urgency

Low

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@makubacki makubacki added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps and removed state:needs-triage Needs to triaged to determine next steps labels Aug 15, 2023
@github-actions github-actions bot added state:needs-owner Needs an issue owner to be assigned state:needs-triage Needs to triaged to determine next steps urgency:low Little to no impact labels Aug 15, 2023
This was referenced Aug 15, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
makubacki pushed a commit to microsoft/mu_tiano_plus that referenced this issue Aug 15, 2023
@Javagedes
[202102] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#167)
6bab3b0 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_tiano_plus that referenced this issue Aug 15, 2023
@Javagedes
[202108] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#168)
dc2fc68 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_tiano_plus that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#169)
7639894 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_silicon_intel_tiano that referenced this issue Aug 15, 2023
@Javagedes
[202102] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#119)
aca700a 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_silicon_intel_tiano that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#120)
0655442 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_silicon_arm_tiano that referenced this issue Aug 15, 2023
@Javagedes
[202102] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#148)
b6b4ba5 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_silicon_arm_tiano that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#149)
65337cc 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_plus that referenced this issue Aug 15, 2023
@Javagedes
[202102] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#285)
be63e90 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_plus that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#286)
9ed6d58 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_common_intel_min_platform that referenced this issue Aug 15, 2023
@Javagedes
[202102] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#181)
696c4cb 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_common_intel_min_platform that referenced this issue Aug 15, 2023
@Javagedes
[202108] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#182)
0a322bc 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_common_intel_min_platform that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#183)
b6df8bc 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_basecore that referenced this issue Aug 15, 2023
@Javagedes
[202102]Ubuntu-GCC5.yml: Remove Scheduled Jobs (#524)
4ea8dc8 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_basecore that referenced this issue Aug 15, 2023
@Javagedes
[202108] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#525)
5ee0f04 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
makubacki pushed a commit to microsoft/mu_basecore that referenced this issue Aug 15, 2023
@Javagedes
[202111] Ubuntu-GCC5.yml: Remove Scheduled Jobs (#526)
01316e6 
Fixes microsoft/mu#173

CI is currently being ran on this branch twice a week, which is wasting
resources. CI only needs to be run on pull requests.
@github-actions github-actions bot removed the state:needs-owner Needs an issue owner to be assigned label Aug 16, 2023
@makubacki makubacki removed the state:needs-triage Needs to triaged to determine next steps label Aug 16, 2023
@makubacki
Copy link
Member Author

Closing since all PRs are merged to remove the scheduled CI in the pipeline YAML files of the older branches.

julorenz117 pushed a commit to julorenz117/mu that referenced this issue Aug 19, 2024
@kuqin12 @makubacki @kenlautner
[CodeQL] XmlSupportPkg: Fixing CodeQL failures in this package (micro…
e457530 
…soft#173)

# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

Pointer overflow has undefined behavior according to the C and C++
standards.
This change will convert the pointer to `UINTN` prior to the comparison
and leverage
unsigned integer overflow, which is defined, to perform the overflow
check.

There is also an error involving variable comparison between different
width.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [x] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Verified functional on Q35 virtual platform.

## Integration Instructions

N/A

---------

Co-authored-by: Michael Kubacki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Javagedes Javagedes

Labels
type:bug Something isn't working urgency:low Little to no impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makubacki @Javagedes