From 636090d412c7f7dbebfd778a04a8592c8f1a9fb1 Mon Sep 17 00:00:00 2001 From: Taylor Beebe <31827475+TaylorBeebe@users.noreply.github.com> Date: Mon, 1 May 2023 12:47:14 -0700 Subject: [PATCH] Remove MorLockTestApp from Q35 and SBSA (#511) ## Description Remove MorLockTestApp from Q35 and SBA and link bugzilla related to the omission reason. - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested N/A ## Integration Instructions N/A --- Platforms/QemuQ35Pkg/PlatformBuild.py | 1 - Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc | 3 ++- Platforms/QemuSbsaPkg/PlatformBuild.py | 1 - Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc | 3 ++- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Platforms/QemuQ35Pkg/PlatformBuild.py b/Platforms/QemuQ35Pkg/PlatformBuild.py index 38c9334e1..e1de08569 100644 --- a/Platforms/QemuQ35Pkg/PlatformBuild.py +++ b/Platforms/QemuQ35Pkg/PlatformBuild.py @@ -30,7 +30,6 @@ FAILURE_EXEMPT_TESTS = { "BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), - "MorLockFunctionalTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), diff --git a/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc b/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc index b5ec3d795..215583142 100644 --- a/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc +++ b/Platforms/QemuQ35Pkg/QemuQ35Pkg.dsc @@ -1366,8 +1366,9 @@ # UefiTestingPkg/AuditTests/UefiVarLockAudit/UEFI/UefiVarLockAuditTestApp.inf # DOESN'T PRODUCE OUTPUT UefiTestingPkg/FunctionalSystemTests/ExceptionPersistenceTestApp/ExceptionPersistenceTestApp.inf UefiTestingPkg/FunctionalSystemTests/MemmapAndMatTestApp/MemmapAndMatTestApp.inf - UefiTestingPkg/FunctionalSystemTests/MorLockTestApp/MorLockTestApp.inf # UefiTestingPkg/FunctionalSystemTests/SmmPagingProtectionsTest/App/SmmPagingProtectionsTestApp.inf # NOT APPLICABLE TO Q35 + # MOR LOCK NOT COMPATIBLE WITH STANDALONE MM: https://bugzilla.tianocore.org/show_bug.cgi?id=3513 + # UefiTestingPkg/FunctionalSystemTests/MorLockTestApp/MorLockTestApp.inf UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/MemoryProtectionTestApp.inf UefiTestingPkg/FunctionalSystemTests/SmmPagingProtectionsTest/Smm/SmmPagingProtectionsTestSmm.inf UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/Smm/MemoryProtectionTestSmm.inf diff --git a/Platforms/QemuSbsaPkg/PlatformBuild.py b/Platforms/QemuSbsaPkg/PlatformBuild.py index 21c400832..b7fbb3647 100644 --- a/Platforms/QemuSbsaPkg/PlatformBuild.py +++ b/Platforms/QemuSbsaPkg/PlatformBuild.py @@ -31,7 +31,6 @@ FAILURE_EXEMPT_TESTS = { "BootAuditTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "LineParserTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), - "MorLockFunctionalTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "MsWheaEarlyUnitTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "VariablePolicyFuncTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), "DeviceIdTestApp.efi": datetime.datetime(2023, 3, 7, 0, 0, 0), diff --git a/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc b/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc index 64d165485..f08034851 100644 --- a/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc +++ b/Platforms/QemuSbsaPkg/QemuSbsaPkg.dsc @@ -1215,7 +1215,8 @@ # UefiTestingPkg/AuditTests/UefiVarLockAudit/UEFI/UefiVarLockAuditTestApp.inf # DOESN'T PRODUCE OUTPUT # UefiTestingPkg/FunctionalSystemTests/ExceptionPersistenceTestApp/ExceptionPersistenceTestApp.inf # NOT APPLICABLE TO SBSA UefiTestingPkg/FunctionalSystemTests/MemmapAndMatTestApp/MemmapAndMatTestApp.inf - UefiTestingPkg/FunctionalSystemTests/MorLockTestApp/MorLockTestApp.inf + # MOR LOCK NOT COMPATIBLE WITH STANDALONE MM: https://bugzilla.tianocore.org/show_bug.cgi?id=3513 + # UefiTestingPkg/FunctionalSystemTests/MorLockTestApp/MorLockTestApp.inf # UefiTestingPkg/FunctionalSystemTests/SmmPagingProtectionsTest/App/SmmPagingProtectionsTestApp.inf # NOT APPLICABLE TO SBSA # UefiTestingPkg/FunctionalSystemTests/MemoryProtectionTest/App/MemoryProtectionTestApp.inf # NOT YET SUPPORTED ON SBSA # UefiTestingPkg/FunctionalSystemTests/SmmPagingProtectionsTest/Smm/SmmPagingProtectionsTestSmm.inf # NOT APPLICABLE TO SBSA