Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] v1.20.0 min GCC version can't build on armv8 #22837

Open
AxelZi opened this issue Nov 14, 2024 · 1 comment
Open

[Build] v1.20.0 min GCC version can't build on armv8 #22837

AxelZi opened this issue Nov 14, 2024 · 1 comment
Labels
build build issues; typically submitted using template contributions welcome lower priority issues for the core ORT teams

Comments

@AxelZi
Copy link

AxelZi commented Nov 14, 2024

Describe the issue

The GCC version is checked to be at least version 9 in the CMakeLists.txt.

if("${CMAKE_C_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_C_COMPILER_VERSION VERSION_LESS 9)

When building on armv8 with GCC 9 the check further down fails

check_cxx_compiler_flag(-march=armv8.2-a+bf16 HAS_ARM64_BFLOAT16)

It seems the feature modifier bf16 was introduced in GCC 10 see here.
If I'm not mistaken the minimum GCC version checked for should be rather be 10 instead of 9.

Urgency

No response

Target platform

armv8

Build script

Using build.py with --parallel 4 --config Release --build_dir build --cmake_extra_defines FETCHCONTENT_TRY_FIND_PACKAGE_MODE=NEVER

Error / output

-- Performing Test HAS_ARM64_BFLOAT16 - Failed
CMake Error at CMakeLists.txt:695 (message):
  The compiler doesn't support BFLOAT16!!!

Visual Studio Version

No response

GCC / Compiler Version

9.5.0

@AxelZi AxelZi added the build build issues; typically submitted using template label Nov 14, 2024
@snnn
Copy link
Member

snnn commented Nov 14, 2024

We only tested the code with GCC 11,12 and 13. And I know in some cases even GCC 11 doesn't work. For example, RHEL 9 has GCC 11, and its assembler cannot be used for compiling our code.

@snnn snnn added the contributions welcome lower priority issues for the core ORT teams label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build issues; typically submitted using template contributions welcome lower priority issues for the core ORT teams
Projects
None yet
Development

No branches or pull requests

2 participants