Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in chunk creation with multiple uris in asset_storage #199

Open
TomAugspurger opened this issue May 4, 2023 · 0 comments
Open

Bug in chunk creation with multiple uris in asset_storage #199

TomAugspurger opened this issue May 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@TomAugspurger
Copy link
Contributor

In #198, I'm attempting to use multiple uris to collect assets under two different prefixes into the same collection

collections:
  - id: cil-gdpcir-cc-by
    template: ${{ local.path(./collection/cil-gdpcir-cc-by) }}
    class: pctasks.dataset.collection:PremadeItemCollection
    asset_storage:
      - uri: blob://rhgeuwest/cil-gdpcir-stac
        token: ${{ pc.get_token(rhgeuwest, cil-gdpcir-stac) }}
        chunks:
          options:
            name_starts_with: CC-BY-4.0/

      - uri: blob://rhgeuwest/cil-gdpcir-stac
        token: ${{ pc.get_token(rhgeuwest, cil-gdpcir-stac) }}
        chunks:
          options:
            name_starts_with: CC-BY-SA-4.0/

When I run this, I noticed that both output to the same file. Here are their outputs:

      {
        "uri": "blob://rhgeuwest/cil-gdpcir-etl-data/chunks/cc-by/2023-05-03-cc-by-fix/assets/all/rhgeuwest/cil-gdpcir-stac/0/uris-list.csv",
        "chunk_id": "rhgeuwest/cil-gdpcir-stac/0/uris-list.csv"
      }

and

      {
        "uri": "blob://rhgeuwest/cil-gdpcir-etl-data/chunks/cc-by/2023-05-03-cc-by-fix/assets/all/rhgeuwest/cil-gdpcir-stac/0/uris-list.csv",
        "chunk_id": "rhgeuwest/cil-gdpcir-stac/0/uris-list.csv"
      }

Perhaps we need to coordinate partition numbers among the two? Or add some extra level to the path; something like the index of the mapping under assset_storage?

@TomAugspurger TomAugspurger added the bug Something isn't working label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant