From da5d4753d6a7a5ebc245bd84f5885cff8948611b Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Fri, 1 Sep 2023 16:33:34 +0200 Subject: [PATCH] chore: add alt tags to images (#1144) --- package.json | 2 +- src/components/GitHubStarButton/index.tsx | 2 ++ src/pages/index.tsx | 37 ++++++++++++----------- src/pages/versions.tsx | 5 ++- tsconfig.json | 6 ++-- 5 files changed, 27 insertions(+), 25 deletions(-) diff --git a/package.json b/package.json index bba72850895..1de727e358a 100644 --- a/package.json +++ b/package.json @@ -25,7 +25,7 @@ "build-python": "npm run cleanup && cp -r python/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/python", "build-java": "npm run cleanup && cp -r java/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/java", "build-dotnet": "npm run cleanup && cp -r dotnet/* . && node --max-old-space-size=4096 node_modules/.bin/docusaurus build --out-dir=build/dotnet", - "build": "rm -rf build && npm run build-nodejs && npm run build-python && npm run build-java && npm run build-dotnet", + "build": "tsc && rm -rf build && npm run build-nodejs && npm run build-python && npm run build-java && npm run build-dotnet", "version-dotnet": "npm run prepare-dotnet && docusaurus docs:version stable && cp -r docs/* dotnet/docs/ && cp -r versioned_docs/* dotnet/versioned_docs/ && cp -r versioned_sidebars/* dotnet/versioned_sidebars/ && cp versions.json dotnet/", "version-java": "npm run prepare-java && docusaurus docs:version stable && cp -r docs/* java/docs/ && cp -r versioned_docs/* java/versioned_docs/ && cp -r versioned_sidebars/* java/versioned_sidebars/ && cp versions.json java/", "version-node": "npm run prepare-nodejs && docusaurus docs:version stable && cp -r docs/* nodejs/docs/ && cp -r versioned_docs/* nodejs/versioned_docs/ && cp -r versioned_sidebars/* nodejs/versioned_sidebars/ && cp versions.json nodejs/", diff --git a/src/components/GitHubStarButton/index.tsx b/src/components/GitHubStarButton/index.tsx index ff3abce664b..fbca193b25a 100644 --- a/src/components/GitHubStarButton/index.tsx +++ b/src/components/GitHubStarButton/index.tsx @@ -9,6 +9,8 @@ type StarButtonProps = { const STARS = '54k+'; // NOTE: this line is generated by src/generate.js. Do not change! const StarButton: React.FC = ({owner, repo}) => { + if (!repo) + throw new Error('repo is required'); return ( = ({ imageUrl, title, description, link }) => { +const Feature: React.FC = ({ imageUrl, title, description }) => { const imgUrl = useBaseUrl(imageUrl); return (
@@ -182,32 +181,36 @@ const FeatureRow: React.FC = ({ title, description, videoUrl, i } const logos = [ - { imageUrl: "img/logos/VSCode.png", href: "https://code.visualstudio.com" }, - { imageUrl: "img/logos/Bing.png", href: "https://bing.com" }, - { imageUrl: "img/logos/Outlook.png", href: "https://outlook.com" }, - { imageUrl: "img/logos/DHotstar.jpg", href: "https://www.hotstar.com/" }, + { imageUrl: "img/logos/VSCode.png", href: "https://code.visualstudio.com", alt: "VS Code" }, + { imageUrl: "img/logos/Bing.png", href: "https://bing.com", alt: "Bing" }, + { imageUrl: "img/logos/Outlook.png", href: "https://outlook.com", alt: "Outlook" }, + { imageUrl: "img/logos/DHotstar.jpg", href: "https://www.hotstar.com/", alt: "Disney+ Hotstar" }, { imageUrl: "img/logos/MUI.png", href: "https://github.com/mui-org/material-ui", + alt: "Material UI", }, - { imageUrl: "img/logos/ING.png", href: "https://github.com/ing-bank/lion" }, + { imageUrl: "img/logos/ING.png", href: "https://github.com/ing-bank/lion", alt: "ING" }, { imageUrl: "img/logos/Adobe2.png", href: "https://github.com/adobe/spectrum-web-components", + alt: "Adobe", }, { imageUrl: "img/logos/ReactNavigation.png", href: "https://github.com/react-navigation/react-navigation", + alt: "React Navigation", }, { imageUrl: "img/logos/accessibilityinsights.png", href: "https://accessibilityinsights.io/", + alt: "Accessibility Insights", }, ]; const Home: React.FC = () => { const context = useDocusaurusContext(); - const { siteConfig = {} } = context; + const { siteConfig } = context; return ( { > Get started - +
@@ -234,9 +237,9 @@ const Home: React.FC = () => {




-
- -
+
+ Browsers (Chromium, Firefox, WebKit) +
@@ -253,10 +256,10 @@ const Home: React.FC = () => {

Chosen by companies and open source projects

    - {logos.map(({ imageUrl, href }, idx) => ( + {logos.map(({ imageUrl, href, alt }, idx) => (
  • - - + + {alt}
    • ))} diff --git a/src/pages/versions.tsx b/src/pages/versions.tsx index 368ebd349f9..00f1cb97614 100644 --- a/src/pages/versions.tsx +++ b/src/pages/versions.tsx @@ -8,8 +8,8 @@ import { } from '@docusaurus/plugin-content-docs/client'; const Version: React.FC = () => { - const versions = useVersions(); - const latestVersion = useLatestVersion(); + const versions = useVersions(undefined); + const latestVersion = useLatestVersion(undefined); const currentVersion = versions.find((version) => version.name === 'current'); const pastVersions = versions.filter( (version) => version !== latestVersion && version.name !== 'current', @@ -20,7 +20,6 @@ const Version: React.FC = () => { return (

    Versions

    diff --git a/tsconfig.json b/tsconfig.json index 6062fdad18d..dc136003018 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,9 +1,7 @@ { "extends": "@tsconfig/docusaurus/tsconfig.json", - "include": [ - "src/" - ], "compilerOptions": { - "downlevelIteration": true + "baseUrl": ".", + "downlevelIteration": true }, }