spacy_nlp_engine: missing spacy.cli

[tigersoldier]

Describe the bug
In spacy_nlp_engine.py, it only imports spacy but calls spacy.cli.download:

presidio/presidio-analyzer/presidio_analyzer/nlp_engine/spacy_nlp_engine.py

Line 64 in a21a17c

spacy.cli.download(model_name)

This will throw the following exception for spacy <= 3.7.0

    @staticmethod
    def _download_spacy_model_if_needed(model_name: str) -> None:
        if not (spacy.util.is_package(model_name) or Path(model_name).exists()):
            logger.warning(f"Model {model_name} is not installed. Downloading...")
>           spacy.cli.download(model_name)
E           AttributeError: module 'spacy' has no attribute 'cli'

.venv/lib/python3.10/site-packages/presidio_analyzer/nlp_engine/spacy_nlp_engine.py:65: AttributeError

Spacy 3.7.1 has spacy.cli imported when you import spacy only. So either fixed the code to explicitly import spacy.cli, or update the dependency requirement to depend on spacy>=3.7.1

To Reproduce
Steps to reproduce the behavior:

1. Install spacy==3.7.0
2. Call create_engine that triggers this path

Expected behavior
Should not throw this exception

Screenshots
N/A

Additional context
N/A

[omri374]

Thanks, this is a change in behavior that the spaCy team quickly reverted:
explosion/spaCy#13039
explosion/spaCy#13040

[omri374]

As far as I know, this issue happens only in version 3.7.0, so 3.6.9 and 3.7.1 should still work.

[tigersoldier]

You are right. So maybe disallowing spacy 3.7.0 in the project.toml should be good enough?

[omri374]

Yes. Would you be interested in creating a PR?