Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumb for Code Eval docs #6069

Open
Jaqster opened this issue Jan 17, 2025 · 4 comments · May be fixed by microsoft/pxt#10353
Open

Breadcrumb for Code Eval docs #6069

Jaqster opened this issue Jan 17, 2025 · 4 comments · May be fixed by microsoft/pxt#10353
Assignees
@abchatra @ganicke
Labels
documentation

Comments

@Jaqster
Copy link
Member

Jaqster commented Jan 17, 2025

Abhijith noticed that the breadcrumb page header for the Code Eval docs page (https://makecode.microbit.org/code-eval-tool) shows "Visual Studio Code support". Not sure where this is coming from, but can we change it? Maybe put it under "Miscellaneous"?

Image
@ganicke
Copy link
Collaborator

ganicke commented Jan 20, 2025

So, if I add /code-eval-tool to Miscellaneous in the extended SUMMARY, then there's a collision with the /code entry in Developers section in the base SUMMARY:

Image

## Miscellaneous #misc

* Miscellaneous
    * [About](/about)
    * [Support](/support)
    * [Translate](/translate)
    * [Sharing projects](/share)
    * [Offline support](/offline)
    * [Save](/save)    
    * [Sign In](/identity/sign-in)
    * [Cloud Sync](/identity/cloud-sync)
    * [Code Evaluation Tool](/code-eval-tool)
    * [Home Page Content](/homepage-content)

However, if I remove the Developers section from the base SUMMARY in pxt-core then it works OK:

Image

It's not supposed to work this way.

@Jaqster
Copy link
Member Author

Jaqster commented Jan 21, 2025

Hmmm... that is weird. @abchatra - do you know what's going on with the docs hierarchy?

@ganicke
Copy link
Collaborator

ganicke commented Jan 21, 2025 •
edited
Loading

What seems to be happening is that the path match to the TOC entry is short circuited at code such that code-eval-tool is also matched to * [Visual Studio Code support](/code). All I have to do is change a letter like o to a, say * [Visual Studio Code support](/cade), and the path match for code-eval-tool works properly.

@abchatra
Copy link
Collaborator

thanks @ganicke will take a look tomorrow.

@ganicke ganicke linked a pull request Jan 25, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abchatra abchatra

@ganicke ganicke

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Terminate TOC recursion on full filepath match microsoft/pxt
3 participants
@abchatra @Jaqster @ganicke