-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify dependencies handling for exercises in katas #1640
Comments
@tcNickolas
May I work on this issue? |
Yes, absolutely! |
Clarification for question 2 |
Yes please! |
@tcNickolas |
You'll need to fork the microsoft/qsharp repository to your account, and then you will be able to create a branch in ggridin/qsharp repository and send the pull request from that branch to the main repo. |
…#1674) Link to the issue: #1640 The following changes were done: 1. qsDependencies property is no longer processing (generate_katas_content.js) 2. ../KatasLibrary.qs is included as implicit dependency 3. ./Common.qs is included as implicit dependency if present in current kata 4. All qsDependencies properties are removed from index.md's 5. README.md is updated - reference to qsDependencies is removed Testing done: 1. "Happy path": Windows cmd build: "python ./build.py --wasm --npm --play" - success Local playground manual testing - no impact (Chrome and Edge) 2. No impact when qsDependencies are present in index.md 3. No impact when qsDependencies are present and empty in index.md Question: should Ubuntu build be tested?
Is your feature request related to a problem? Please describe.
Currently each exercise in each kata has a field
qsDependencies
that lists files that need to be compiled together with the files of that specific exercise.This is very repetitive, leads to hard-to-debug issues when contributing to the katas, and unnecessary, since the logic of including the files is the same across all katas.
Describe the solution you'd like
I'd like to drop this field and instead, when an exercise is created, to include the files using the following logic:
Describe alternatives you've considered
We can keep the current approach.
The text was updated successfully, but these errors were encountered: