Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure port to generated Microservice should be allowed #3

Open
yaweiw opened this issue Jun 12, 2018 · 0 comments
Open

configure port to generated Microservice should be allowed #3

yaweiw opened this issue Jun 12, 2018 · 0 comments
Assignees
@Incarnation-p-lee
Labels
new feature

Comments

@yaweiw
Copy link
Contributor

yaweiw commented Jun 12, 2018

  • ProjectRequest should contain the configured port.
  • Port conflict should be detected and there should be a fallback mechanism.
Incarnation-p-lee added a commit that referenced this issue Jun 21, 2018
@Incarnation-p-lee
Add configurable port to website, #3.
93762be 
* Allow customize service port from website.

* Detect invalid port configuration and provide default port.

Signed-off-by: Pan Li <[email protected]>
Incarnation-p-lee added a commit that referenced this issue Jun 21, 2018
@Incarnation-p-lee
Add configurable port to website, #3.
d06fed6 
* Allow customize service port from website.

* Detect invalid port configuration and provide default port.

Signed-off-by: Pan Li <[email protected]>
Incarnation-p-lee added a commit that referenced this issue Jun 22, 2018
@Incarnation-p-lee
Add configurable port to website, #3. (PR #18)
0988cb0 
* Add configurable port to website, #3.

* Allow customize service port from website.

* Detect invalid port configuration and provide default port.

Signed-off-by: Pan Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Incarnation-p-lee Incarnation-p-lee

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Incarnation-p-lee @yaweiw