-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I/O Bench: add new dataset #1972
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
testing
Continuous integration testing
datamodules
PyTorch Lightning datamodules
documentation
Improvements or additions to documentation
trainers
PyTorch Lightning trainers
labels
Apr 1, 2024
adamjstewart
force-pushed
the
datasets/iobench
branch
from
April 4, 2024 18:43
a095943
to
aa60ec9
Compare
Trying to resist the urge to write a custom profiler that automatically formats the output we care about as a Markdown table: https://lightning.ai/docs/pytorch/stable/tuning/profiler_expert.html |
This was referenced Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
datamodules
PyTorch Lightning datamodules
datasets
Geospatial or benchmark datasets
documentation
Improvements or additions to documentation
testing
Continuous integration testing
trainers
PyTorch Lightning trainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our paper includes an I/O performance benchmark consisting of 114 Landsat 8 Level-2 scenes and 1 CDL 2019 mask. Since its publication, we have not been benchmarking I/O during PRs or between releases. This has led to difficulty in properly evaluating proposed changes (#1881) and massive performance bugs that have gone undetected for years (#1968).
This PR adds a dataset to properly test this. It consists of a single Landsat 9 scene and CDL mask with the following splits:
These roughly correspond to the same categories as used in our paper, with a few changes:
These changes are made to make the dataset as small as possible so it can be quickly downloaded and fit on any system. I believe that the dataset is still useful even at such a small size. This should be considered to be version 1 of the dataset, with many future changes to evaluate a broader set of conditions.
Sample image over Champaign County, IL, USA:
This PR also represents an interesting and novel dataset design. Note that instead of writing a custom
RasterDataset
and overriding__getitem__
to handle both Landsat and CDL files, I'm actually subclassing fromIntersectionDataset
, instantiating Landsat and CDL classes, and computing the intersection. This is significantly easier and could be used to simplify our implementations of other raster datasets with both images and masks: AgriFieldNet, Chesapeake, EnviroAtlas, GlobBiomass, L7 Irish, L8 Biome, LandCover.ai, etc.FYI @yichiac
Closes #190