Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7zip] restore missing sources and fix compilation on android #42911

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[7zip] restore missing sources and fix compilation on android #42911

wants to merge 4 commits into from
+32 −15

Conversation

msclock
Copy link
Contributor

@msclock msclock commented Dec 24, 2024 •
edited
Loading

Fixes #42910

References #41721, #41743

@msclock msclock marked this pull request as draft December 24, 2024 09:42
@msclock
Copy link
Contributor Author

msclock commented Dec 24, 2024 •
edited
Loading

@DanAlbert in #41721, for This fixes compilation errors with NDK r28., Could you explain your compilation errors in detail. Thanks.

Still skip failures from Android or do more investigation🤔🤔

@dg0yt
Copy link
Contributor

dg0yt commented Dec 24, 2024 •
edited
Loading

Why should the sources in the Windows directory be added to a non-WIN32 build?

@msclock
Copy link
Contributor Author

msclock commented Dec 24, 2024 •
edited
Loading

Why should the sources in the Windows directory be added to a non-WIN32 build?

@dg0yt see #42910

@dg0yt
Copy link
Contributor

dg0yt commented Dec 24, 2024

@dg0yt see #42910

I have seen that already.

@msclock
Copy link
Contributor Author

msclock commented Dec 24, 2024 •
edited
Loading

Why should the sources in the Windows directory be added to a non-WIN32 build?

AFAIK, 7zip uses win32 com api to implement a plugin loading way, so it implements the same api on linux. And Some api are placed in that Windows directory and refered by sources under the directory CPP/7zip/Archive with relative paths.

But in detail should ask the author of the initial port PR.

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Dec 25, 2024
@msclock msclock force-pushed the 7zip branch 3 times, most recently from 464fb0b to 7d3db93 Compare December 25, 2024 07:30
@msclock msclock marked this pull request as ready for review December 25, 2024 07:53
@msclock
Copy link
Contributor Author

msclock commented Dec 25, 2024

@DanAlbert in #41721, for This fixes compilation errors with NDK r28., Could you explain your compilation errors in detail. Thanks.

Still skip failures from Android or do more investigation🤔🤔

@dg0yt @DanAlbert The failure is timespec_get is broken on android and I have handled it.

@msclock msclock changed the title [7zip] restore missing sources in CMakeLists.txt [7zip] restore missing sources and fix compilation on android Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[7zip] Some implementations aren't compiled
3 participants
@msclock @dg0yt @WangWeiLin-MV