Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a decompiler to the pack #18

Closed
iamatypeofwalrus opened this issue Feb 14, 2018 · 8 comments
Closed

Add a decompiler to the pack #18

iamatypeofwalrus opened this issue Feb 14, 2018 · 8 comments
Assignees

Comments

@iamatypeofwalrus
Copy link

Hey!

I'd like to propose adding the Java Decompiler extension to this pack.

I've been using the pack on a few projects at my day job. Due to our custom build system our dependencies are mostly prepackaged in Jars. The go to definition command makes a reasonable effort to decompile our dependencies out of the box but it isn't able to bring up the implementation details.

The Java decompiler extension works out of the box with the Red Hat extension and is able to decompile the classes and provide implementation details. 👍

@andxu andxu self-assigned this Mar 7, 2018
@andxu
Copy link
Contributor

andxu commented Mar 7, 2018

We need some investigation about whether it is compatible with java debug/test/maven plugins

@akaroml
Copy link
Member

akaroml commented Oct 25, 2019

@testforstephen could you take a look and evaluate the extension?

@testforstephen
Copy link
Contributor

testforstephen commented Oct 29, 2019

I have a try on the decompiler extension, it provides a good feature to decompile the .class file without source file, but missed some important features.

If you want the extension to be added to the pack, i wish to see these two issues to be addressed. At least, solve the first one first.

  • The basic language server features don't work in the auto generated code. For example, "Go to Definition" doesn't work in the decompiled code. See issue#8
  • The decompiled code can't be used for debugging because of line number not match. See issue#4

// fyi @dgileadi (the author)

@akaroml
Copy link
Member

akaroml commented Dec 3, 2019

Thanks, @testforstephen for the evaluation.

@thinkiny
Copy link

any progress ?

@akaroml
Copy link
Member

akaroml commented Dec 19, 2019

any progress ?

There are unresolved issues, see comments from @testforstephen. We need to get those issue addressed before we recommend that extension to everyone by putting it in the extension pack.

In the short term, please install the decompiler extension yourself and see if it resolves your problem. And we appreciate your feedback on how it works.

@testforstephen
Copy link
Contributor

redhat java extension has integrated a built-in fernflower decompiler, no need to include a 3rd party decompiler any more.

@cklee75
Copy link

cklee75 commented Sep 6, 2024

redhat java extension has integrated a built-in fernflower decompiler, no need to include a 3rd party decompiler any more.

However the built-in fernflower decompiler does not maintain the original line numbers, even the class or jar still has the debug information. You can't navigate to exact line that threw exception from stack trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants