Upgrade to Node 20 broke the launching of cmd files on windows

[JVApen]

I've already encountered this issue for 2 different extensions:

• CMake executable cannot be a script vscode-cmake-tools#4037 (comment)
• No longer possible to use cmd as clangd executable clangd/vscode-clangd#683

In version 1.91, it was possible to use a .cmd file as an executable. This is very useful if the exact executable depends on some external elements (for example: We download this via nuget and if we add a fix, the new version gets automatically distributed)
From version 1.92, the cmd files are no longer launched

[dbaeumer]

This is caused by a breaking change in Node itself. To launch a cmd you know need to pass shell: true. See https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/node/main.ts#L64

Let me know if this helps.

[JVApen]

As I'm not the author of those extensions, I cannot pass that flag. I did log bugs with those extensions as you can see above.

[dbaeumer]

@JVApen I will close the issue since this is nothing I can fix in the LSP libraries.

[dbaeumer]

I commented in one of the issues you open to point to the breaking change in NodeJS