Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill all subprocesses when main process is killed #208

Open
apanariello4 opened this issue Feb 12, 2024 · 2 comments
Open

Kill all subprocesses when main process is killed #208

apanariello4 opened this issue Feb 12, 2024 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality needs community feedback

Comments

@apanariello4
Copy link

vscode: 1.86.1
python: 3.11.5
python-debugger: v2024.1.10371006

When debugging inside part of code with multiple processes (e.g., inside get_item of pytorch dataset), multiple subprocesses are found, and one can switch between those. However, when killing the main process, all other subprocesses are kept alive, and the debugger hangs, waiting for all to be killed or continued.

Adding a feature that kills all subprocesses when the main is killed would be helpful to avoid having to spam the stop button.

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 12, 2024
@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Feb 12, 2024
@paulacamargo25 paulacamargo25 added needs community feedback and removed triage-needed Needs assignment to the proper sub-team labels Jun 1, 2024
@paulacamargo25
Copy link
Contributor

Thanks for the feature request! We are going to give the community 60 days to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@kalingibbons
Copy link

I gave this one a 👍 , but I think it has more to do with the small debug-panel on the top. Before the debugpy integration, hitting the stop button or refresh button would terminate the main process. Now I have to open the debug panel, scroll to the top process, then interact with the buttons in the hovers to restart my debug sessions. Would love a configurable option to have my hotkeys always operate on the main process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality needs community feedback
Projects
None yet
Development

No branches or pull requests

5 participants