Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PYTHONSTARTUP default to true #24141

Open
anthonykim1 opened this issue Sep 20, 2024 · 1 comment
Open

Make PYTHONSTARTUP default to true #24141

anthonykim1 opened this issue Sep 20, 2024 · 1 comment
Assignees
@anthonykim1
Labels
area-repl area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
November 2024

Comments

@anthonykim1
Copy link

anthonykim1 commented Sep 20, 2024 •
edited
Loading

Related: #24140

The default to enable shell integration in Python Terminal REPL via setting PYTHONSTARTUP environment variable has been set to false to target September release version of the Python extension.

  • After stable release, we could roll the default as true for pre-release users ONLY in October, make sure we are not breaking anyone's Python terminal REPL.

  • Eventually make default for PYTHONSTARTUP (enable shell integration for Python terminal REPL) as true for release/stable versions after some feedback in November.
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-terminal area-repl labels Sep 20, 2024
@anthonykim1 anthonykim1 self-assigned this Sep 20, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 20, 2024
@anthonykim1 anthonykim1 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Sep 20, 2024
@anthonykim1 anthonykim1 mentioned this issue Sep 20, 2024
Closed
@anthonykim1 anthonykim1 added this to the October 2024 milestone Sep 20, 2024
@anthonykim1 anthonykim1 mentioned this issue Sep 20, 2024
Merged
anthonykim1 added a commit that referenced this issue Sep 20, 2024
@anthonykim1
add experimental tag for enableShellIntegration (#24144)
336a110 
To better control flow of:
#24141
Adding experimental tag:
This way, we are able to control the default value without having to
recovery release in the worst case scenario.
@karthiknadig
Copy link
Member

This should be in experiment. So, we should be able to switch it after the experiment is 100% both insiders and stable.

@anthonykim1 anthonykim1 mentioned this issue Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
November 2024
Development

No branches or pull requests
2 participants
@karthiknadig @anthonykim1