-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal DOM renderer clips the top of the cell, cutting off tall glyphs like U+23A1 ⎡ #172504
Comments
works for me on mac for all values of rendering.mov |
does not work on windows |
@meganrogge dom too? What's your font family, line height, etc.? |
Also dom and I don't set font or line height |
Can repro when I unset fontFamily: This is somewhat expected because of the weird vertical offset with this font:
Even ddg and other websites clip this: |
It's working on all but the first line on the webgl renderer which makes sense. Not sure how to action this issue, but an easy workaround is switching fonts to one that doesn't vertically offset this char. |
Should we set a default font family for ppl so that the majority won't encounter this issue? |
That's a pretty big impact/scary change, we would only want to do that if we changed the default monospace font everywhere |
Upstream: xtermjs/xterm.js#5240 The fact that this is cut off for the webgl renderer on the first line only is by design. |
Does this issue occur when all extensions are disabled?: Yes
Problem:
The VSCode terminal display of Unicode characters U+23A1 (
⎡
) and U+23A4 (⎤
) is mangled and looks more similar to U+23A2 or U+23A5 instead (⎢
). These characters are helpful in rendering matrices properly.Steps to Reproduce:
⎡ ⎤
into the VSCode terminal: observe that they are wrongly rendered:The text was updated successfully, but these errors were encountered: