Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff selection uses menu.border to highlight range which is not set for many themes #228819

Open
a-stewart opened this issue Sep 17, 2024 · 1 comment · May be fixed by #228825
Open

Diff selection uses menu.border to highlight range which is not set for many themes #228819

a-stewart opened this issue Sep 17, 2024 · 1 comment · May be fixed by #228825
Assignees

Comments

@a-stewart
Copy link
Contributor

When you select a range in a diff, a hint is shown in the gutter to show which range is in use.

image

This colour is specified by menu.border which is a little surprising.

What is more of a concern is that this colour has no default value and is not set for a lot of themes. Including many of the default themes.

Here is Dark+ on github.dev:
image

Conversely here is the built in Monokai:
image

Or Solaraized Dark:
image

On third party themes we see much of the same.

@a-stewart
Copy link
Contributor Author

One option could be to use menu.separatorBackground instead of menu.border as the colour that is used for this hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants